Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert smiley in a widget #134

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Insert smiley in a widget #134

merged 1 commit into from
Oct 9, 2024

Conversation

Cyperghost
Copy link
Contributor

@Cyperghost Cyperghost requested a review from dtdesign October 9, 2024 08:41
@dtdesign
Copy link
Member

dtdesign commented Oct 9, 2024

Please move this to main for now. Smileys are present in a lot of messages and the new <span> could introduce regressions therefore we’re targeting 6.1 for now. We can backport the changes if they have proven themselves.

@Cyperghost Cyperghost changed the base branch from 6.0 to main October 9, 2024 12:15
@Cyperghost Cyperghost merged commit 1b3b363 into main Oct 9, 2024
4 of 6 checks passed
@Cyperghost Cyperghost deleted the bugfix/smiley-remove branch October 9, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyperghost @dtdesign