Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert smiley in a widget #134

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions plugins/ckeditor5-woltlab-smiley/src/woltlabsmiley.ts
Original file line number Diff line number Diff line change
@@ -12,6 +12,7 @@ import type { DowncastInsertEvent } from "@ckeditor/ckeditor5-engine";
import { Image } from "@ckeditor/ckeditor5-image";

import "../theme/woltlabsmiley.css";
import { toWidget } from "@ckeditor/ckeditor5-widget";

export class WoltlabSmiley extends Plugin {
static get pluginName() {
@@ -69,13 +70,20 @@ export class WoltlabSmiley extends Plugin {
consumable.consume(item, "insert");

const image = writer.createEmptyElement("img");
const container = writer.createContainerElement(
"span",
{ class: "image-inline" },
image,
);
writer.setAttribute("translate", "no", image);
const position = mapper.toViewPosition(
this.editor.model.createPositionBefore(item),
);
writer.insert(position, image);
toWidget(container, writer);

writer.insert(position, container);

mapper.bindElements(item, image);
mapper.bindElements(item, container);
},
{ priority: "high" },
);

Unchanged files with check annotations Beta

{

Check failure on line 1 in tsconfig.json

GitHub Actions / Prettier

tsconfig.json
"compilerOptions": {
"target": "ES2022",
"module": "amd",