Update Vueuse #2674

obulat · 2023-07-19T03:40:01Z

Fixes

Description

Per @sarayourfriend's suggestion on fixing the SessionStorage permission issue, this PR updates the version of Vueuse to the latest, 10.2.1.

It renames resolveUnref to toValue and MaybeComputedRef to MaybeRefOrGetter to match the Vueuse breaking changes in version 10 ¹.
It also replaces some composables with Vueuse versions.

Testing Instructions

The site should work without any additional warnings in the console, and the CI should pass.

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

https://github.com/vueuse/vueuse/releases/tag/v10.0.0 ↩

github-actions · 2023-07-19T03:46:16Z

Size Change: +2.87 kB (0%)

Total Size: 835 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/app.js`	121 kB	-363 B (0%)
`./frontend/.nuxt/dist/client/app.modern.js`	112 kB	-351 B (0%)
`./frontend/.nuxt/dist/client/commons/app.modern.js`	80.8 kB	+24 B (0%)
`./frontend/.nuxt/dist/client/pages/index.js`	6.34 kB	-21 B (0%)
`./frontend/.nuxt/dist/client/pages/index.modern.js`	6.3 kB	-19 B (0%)
`./frontend/.nuxt/dist/client/vendors/app.js`	68.4 kB	+1.67 kB (+3%)
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	68.1 kB	+1.92 kB (+3%)

ℹ️ View Unchanged

Filename	Size	Change
`./frontend/.nuxt/dist/client/232.js`	272 B	0 B
`./frontend/.nuxt/dist/client/232.modern.js`	276 B	0 B
`./frontend/.nuxt/dist/client/233.js`	1.85 kB	0 B
`./frontend/.nuxt/dist/client/commons/app.js`	90.3 kB	+8 B (0%)
`./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.js`	5.17 kB	0 B
`./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.modern.js`	5.61 kB	0 B
`./frontend/.nuxt/dist/client/components/loading-icon.js`	731 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	735 B	+2 B (0%)
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	514 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	519 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	6.5 kB	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	6.33 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-cell.js`	572 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js`	573 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	1.79 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	1.77 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	959 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	961 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.38 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.34 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	636 B	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	642 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-bone.js`	632 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	636 B	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.33 kB	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.34 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.06 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.05 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-page.js`	531 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	536 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	492 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	497 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	3.33 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.21 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	3.79 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	3.67 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	3.99 kB	-6 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	2.28 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	2.25 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	792 B	0 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	796 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-image.js`	2.41 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	2.38 kB	-5 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	376 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	2 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.99 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	895 B	0 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	896 B	0 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.57 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.58 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.53 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.54 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	4.28 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	4.26 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.8 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.77 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.93 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.92 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-details.js`	1.44 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	1.43 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	4.39 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	4.26 kB	-5 B (0%)
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	640 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	648 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-load-more.js`	1.18 kB	0 B
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	1.07 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-license.js`	933 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	941 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	2.94 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	2.91 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	416 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	420 B	0 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	995 B	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	854 B	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	858 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-radio.js`	1 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.01 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	1.73 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	1.64 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-images.js`	806 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	718 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	976 B	0 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	980 B	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.73 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.74 kB	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	891 B	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	891 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	6.81 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	6.17 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	617 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	621 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	298 B	0 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B	0 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	915 B	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.06 kB	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.07 kB	0 B
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	14.3 kB	-7 B (0%)
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	14.3 kB	-6 B (0%)
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B	0 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B	0 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.42 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.42 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	6.73 kB	+4 B (0%)
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	6.57 kB	+6 B (0%)
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.36 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.36 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	7.04 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	6.86 kB	+5 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	4.89 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.67 kB	+4 B (0%)
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.32 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.32 kB	0 B
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.26 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.26 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.62 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.61 kB	0 B
`./frontend/.nuxt/dist/client/pages/search.js`	2.26 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.05 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/audio.js`	4.1 kB	-5 B (0%)
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	3.98 kB	-5 B (0%)
`./frontend/.nuxt/dist/client/pages/search/image.js`	544 B	-2 B (0%)
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	551 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/index.js`	441 B	0 B
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	447 B	0 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	247 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/search-page.types.js`	265 B	0 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js`	271 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	244 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.js`	1.54 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.54 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/runtime.js`	2.69 kB	0 B
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.69 kB	0 B

_{compressed-size-action}

sarayourfriend

Awesome 👍

Update vueuse version

61460ad

obulat requested a review from a team as a code owner July 19, 2023 03:40

obulat self-assigned this Jul 19, 2023

obulat requested review from AetherUnbound and dhruvkb July 19, 2023 03:40

github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Jul 19, 2023

openverse-bot added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Jul 19, 2023

obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 19, 2023

Revert use-reduced-motion replacement

d472abd

sarayourfriend approved these changes Jul 19, 2023

View reviewed changes

zackkrida approved these changes Jul 19, 2023

View reviewed changes

obulat merged commit cdd5bde into main Jul 19, 2023
41 checks passed

obulat deleted the update_vueuse branch July 19, 2023 14:57

dhruvkb mentioned this pull request Jul 19, 2023

Handle sessionStorage access blocked by browser security #2563

Closed

obulat mentioned this pull request Jul 19, 2023

Stop loading homepage image gallery on smaller screens #2605

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Vueuse #2674

Update Vueuse #2674

obulat commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

sarayourfriend left a comment

Update Vueuse #2674

Update Vueuse #2674

Conversation

obulat commented Jul 19, 2023 • edited Loading

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

Footnotes

github-actions bot commented Jul 19, 2023 • edited Loading

sarayourfriend left a comment

Choose a reason for hiding this comment

obulat commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading