-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SM snapshots for dark mode #5052
Conversation
Latest k6 run output1
Footnotes
|
eca233a
to
63a26fe
Compare
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
63a26fe
to
ae4ab52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As these snapshots accumulate, and since images take a lot of space, it's becoming more pertinent to find a way to move them to another repo so that a brand new copy of the repo doesn't take too many network resources and time to download.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing actionable, just a side comment: I wonder how readable this capture is. It looks a bit small/thin to notice all the details of the characters 😅
Fixes
Related to #4305 by @zackkrida
Description
This PR adds snapshots for SM breakpoint.
Testing Instructions
There should only be dark snapshots added (and the change in
breakpoints.ts
file).The CI should pass.
If there are any problems with the UI, the problems should be noted but not fixed in this PR.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin