New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SM snapshots for dark mode #5052

Merged

obulat merged 2 commits into main from add/dark-mode-snapshots-sm

Oct 19, 2024

frontend/test/playwright/utils/breakpoints.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -96,7 +96,8 @@ const makeBreakpointDescribe = @@
               useColorMode:
                 snapshotName.includes("-2xl") ||
                 snapshotName.includes("-xl") ||
-                snapshotName.includes("-lg"),
+                snapshotName.includes("-lg") ||
+                snapshotName.includes("-sm"),
             })
           }
@@ Expand Down @@

...-section.spec.ts-snapshots/external-audio-sources-popover-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...-section.spec.ts-snapshots/external-audio-sources-popover-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...-section.spec.ts-snapshots/external-image-sources-popover-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...-section.spec.ts-snapshots/external-image-sources-popover-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...omponents/filters.spec.ts-snapshots/filters-modal-checked-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...omponents/filters.spec.ts-snapshots/filters-modal-checked-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...ession/components/filters.spec.ts-snapshots/filters-modal-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...ession/components/filters.spec.ts-snapshots/filters-modal-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...gression/components/header.spec.ts-snapshots/filters-open-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...gression/components/header.spec.ts-snapshots/filters-open-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...al-regression/components/header.spec.ts-snapshots/resting-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...al-regression/components/header.spec.ts-snapshots/resting-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...l-regression/components/header.spec.ts-snapshots/scrolled-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...l-regression/components/header.spec.ts-snapshots/scrolled-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...sion/components/header.spec.ts-snapshots/searchbar-active-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...sion/components/header.spec.ts-snapshots/searchbar-active-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...ion/components/header.spec.ts-snapshots/searchbar-hovered-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...ion/components/header.spec.ts-snapshots/searchbar-hovered-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...l-regression/pages/errors.spec.ts-snapshots/generic-error-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...l-regression/pages/errors.spec.ts-snapshots/generic-error-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...s/errors.spec.ts-snapshots/search-result-audio-no-results-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...s/errors.spec.ts-snapshots/search-result-audio-no-results-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...s/errors.spec.ts-snapshots/search-result-image-no-results-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...s/errors.spec.ts-snapshots/search-result-image-no-results-rtl-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...sion/pages/errors.spec.ts-snapshots/search-result-timeout-ltr-sm-dark-linux.png

Sorry, something went wrong. Reload?

Sorry, we cannot display this file.

Sorry, this file is invalid so it cannot be displayed.

...sion/pages/errors.spec.ts-snapshots/search-result-timeout-rtl-sm-dark-linux.png

...on/pages/homepage.spec.ts-snapshots/content-switcher-open-ltr-sm-dark-linux.png

...on/pages/homepage.spec.ts-snapshots/content-switcher-open-rtl-sm-dark-linux.png

....ts-snapshots/content-switcher-with-external-sources-open-ltr-sm-dark-linux.png

....ts-snapshots/content-switcher-with-external-sources-open-rtl-sm-dark-linux.png

...egression/pages/homepage.spec.ts-snapshots/focused-search-ltr-sm-dark-linux.png

...egression/pages/homepage.spec.ts-snapshots/focused-search-rtl-sm-dark-linux.png

.../visual-regression/pages/homepage.spec.ts-snapshots/index-ltr-sm-dark-linux.png

.../visual-regression/pages/homepage.spec.ts-snapshots/index-rtl-sm-dark-linux.png

...ression/pages/homepage.spec.ts-snapshots/unfocused-search-ltr-sm-dark-linux.png

...ression/pages/homepage.spec.ts-snapshots/unfocused-search-rtl-sm-dark-linux.png

...ts/audio-from-search-results-with-additional-search-views-ltr-sm-dark-linux.png

...ts/audio-from-search-results-with-additional-search-views-rtl-sm-dark-linux.png

...es/pages-single-result.spec.ts-snapshots/full-page-report-ltr-sm-dark-linux.png

...es/pages-single-result.spec.ts-snapshots/full-page-report-rtl-sm-dark-linux.png

...ts/image-from-search-results-with-additional-search-views-ltr-sm-dark-linux.png

...ts/image-from-search-results-with-additional-search-views-rtl-sm-dark-linux.png

...ght/visual-regression/pages/pages.spec.ts-snapshots/about-ltr-sm-dark-linux.png

...ght/visual-regression/pages/pages.spec.ts-snapshots/about-rtl-sm-dark-linux.png

...t/visual-regression/pages/pages.spec.ts-snapshots/privacy-ltr-sm-dark-linux.png

...t/visual-regression/pages/pages.spec.ts-snapshots/privacy-rtl-sm-dark-linux.png

...sual-regression/pages/pages.spec.ts-snapshots/search-help-ltr-sm-dark-linux.png

...sual-regression/pages/pages.spec.ts-snapshots/search-help-rtl-sm-dark-linux.png

...egression/pages/pages.spec.ts-snapshots/sensitive-content-ltr-sm-dark-linux.png

...egression/pages/pages.spec.ts-snapshots/sensitive-content-rtl-sm-dark-linux.png

...t/visual-regression/pages/pages.spec.ts-snapshots/sources-ltr-sm-dark-linux.png

...t/visual-regression/pages/pages.spec.ts-snapshots/sources-rtl-sm-dark-linux.png

...s/search-with-banners.spec.ts-snapshots/page-with-all-banners-sm-dark-linux.png

...tton-components.spec.ts-snapshots/v-load-more-focused-hovered-sm-dark-linux.png

...ustom-button-components.spec.ts-snapshots/v-load-more-focused-sm-dark-linux.png

...ustom-button-components.spec.ts-snapshots/v-load-more-hovered-sm-dark-linux.png

...ustom-button-components.spec.ts-snapshots/v-load-more-resting-sm-dark-linux.png

...visual-regression/v-button.spec.ts-snapshots/bordered-tx-focused-dark-linux.png

...egression/v-button.spec.ts-snapshots/bordered-tx-focused-hovered-dark-linux.png

...gression/v-button.spec.ts-snapshots/bordered-tx-focused-hovered-light-linux.png

...isual-regression/v-button.spec.ts-snapshots/bordered-tx-focused-light-linux.png

...visual-regression/v-button.spec.ts-snapshots/bordered-tx-hovered-dark-linux.png

...isual-regression/v-button.spec.ts-snapshots/bordered-tx-hovered-light-linux.png

...visual-regression/v-button.spec.ts-snapshots/bordered-tx-resting-dark-linux.png

...isual-regression/v-button.spec.ts-snapshots/bordered-tx-resting-light-linux.png

.../v-collection-header.spec.ts-snapshots/VCollectionHeaders-ltr-sm-dark-linux.png

.../v-collection-header.spec.ts-snapshots/VCollectionHeaders-rtl-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-at-rest-0-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-at-rest-1-checked-sm-dark-linux.png

...ter-button.spec.ts-snapshots/filter-button-at-rest-12-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-focused-0-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-focused-1-checked-sm-dark-linux.png

...ter-button.spec.ts-snapshots/filter-button-focused-12-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-hovered-0-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-hovered-1-checked-sm-dark-linux.png

...ter-button.spec.ts-snapshots/filter-button-hovered-12-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-pressed-0-checked-sm-dark-linux.png

...lter-button.spec.ts-snapshots/filter-button-pressed-1-checked-sm-dark-linux.png

...ter-button.spec.ts-snapshots/filter-button-pressed-12-checked-sm-dark-linux.png

...ton.spec.ts-snapshots/filter-button-pressed-focused-0-checked-sm-dark-linux.png

...ton.spec.ts-snapshots/filter-button-pressed-focused-1-checked-sm-dark-linux.png

...on.spec.ts-snapshots/filter-button-pressed-focused-12-checked-sm-dark-linux.png

...ton.spec.ts-snapshots/filter-button-pressed-hovered-0-checked-sm-dark-linux.png

...ton.spec.ts-snapshots/filter-button-pressed-hovered-1-checked-sm-dark-linux.png

...on.spec.ts-snapshots/filter-button-pressed-hovered-12-checked-sm-dark-linux.png

...sual-regression/v-footer.spec.ts-snapshots/footer-content-ltr-sm-dark-linux.png

...sual-regression/v-footer.spec.ts-snapshots/footer-content-rtl-sm-dark-linux.png

...ual-regression/v-footer.spec.ts-snapshots/footer-internal-ltr-sm-dark-linux.png

...ual-regression/v-footer.spec.ts-snapshots/footer-internal-rtl-sm-dark-linux.png

...er-internal.spec.ts-snapshots/mobile-header-internal-open-ltr-sm-dark-linux.png

...er-internal.spec.ts-snapshots/mobile-header-internal-open-rtl-sm-dark-linux.png

...ession/v-media-license.spec.ts-snapshots/v-media-license-cc-0-sm-dark-linux.png

...v-media-license.spec.ts-snapshots/v-media-license-cc-by-nc-nd-sm-dark-linux.png

...v-media-license.spec.ts-snapshots/v-media-license-cc-by-nc-sa-sm-dark-linux.png

...on/v-media-license.spec.ts-snapshots/v-media-license-cc-by-nc-sm-dark-linux.png

...on/v-media-license.spec.ts-snapshots/v-media-license-cc-by-nd-sm-dark-linux.png

...on/v-media-license.spec.ts-snapshots/v-media-license-cc-by-sa-sm-dark-linux.png

...ssion/v-media-license.spec.ts-snapshots/v-media-license-cc-by-sm-dark-linux.png

...v-media-license.spec.ts-snapshots/v-media-license-nc-sampling-sm-dark-linux.png

...ression/v-media-license.spec.ts-snapshots/v-media-license-pdm-sm-dark-linux.png

...on/v-media-license.spec.ts-snapshots/v-media-license-sampling-sm-dark-linux.png

...sion/v-media-reuse.spec.ts-snapshots/media-reuse-html-tab-ltr-sm-dark-linux.png

...sion/v-media-reuse.spec.ts-snapshots/media-reuse-html-tab-rtl-sm-dark-linux.png

...ion/v-media-reuse.spec.ts-snapshots/media-reuse-plain-tab-ltr-sm-dark-linux.png

...ion/v-media-reuse.spec.ts-snapshots/media-reuse-plain-tab-rtl-sm-dark-linux.png

...sion/v-media-reuse.spec.ts-snapshots/media-reuse-rich-tab-ltr-sm-dark-linux.png

...sion/v-media-reuse.spec.ts-snapshots/media-reuse-rich-tab-rtl-sm-dark-linux.png

Member

krysal Oct 18, 2024

Nothing actionable, just a side comment: I wonder how readable this capture is. It looks a bit small/thin to notice all the details of the characters 😅

...ssion/v-media-reuse.spec.ts-snapshots/media-reuse-xml-tab-ltr-sm-dark-linux.png

...ssion/v-media-reuse.spec.ts-snapshots/media-reuse-xml-tab-rtl-sm-dark-linux.png

...cation-banner.spec.ts-snapshots/notificationbanner-error-dark-sm-dark-linux.png

...ion-banner.spec.ts-snapshots/notificationbanner-error-regular-sm-dark-linux.png

...ication-banner.spec.ts-snapshots/notificationbanner-info-dark-sm-dark-linux.png

...tion-banner.spec.ts-snapshots/notificationbanner-info-regular-sm-dark-linux.png

...tion-banner.spec.ts-snapshots/notificationbanner-success-dark-sm-dark-linux.png

...n-banner.spec.ts-snapshots/notificationbanner-success-regular-sm-dark-linux.png

...tion-banner.spec.ts-snapshots/notificationbanner-warning-dark-sm-dark-linux.png

...n-banner.spec.ts-snapshots/notificationbanner-warning-regular-sm-dark-linux.png

...gression/v-safety-wall.spec.ts-snapshots/v-safetywall-default-sm-dark-linux.png