Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local header layout #67

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Update local header layout #67

merged 11 commits into from
Sep 13, 2023

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Sep 5, 2023

Closes WordPress/wporg-main-2022#66

Depends on WordPress/wporg-parent-2021#103, WordPress/wporg-mu-plugins#443 and WordPress/wporg-mu-plugins#439

  • Changes background and border colors
  • Adds site title 'Documentation' on pages other than home

Home header background color can be updated in content.

Screenshots (outdated, see below)

Home

Desktop Mobile
localhost_8888_(Desktop) (2) localhost_8888_(Samsung Galaxy S20 Ultra) (1)

Topic landing page

Desktop Mobile
localhost_8888_technical-guides_(Desktop) localhost_8888_technical-guides_(Samsung Galaxy S20 Ultra)

Article

Desktop Mobile
localhost_8888_article_block-directory_(Desktop) localhost_8888_article_block-directory_(Samsung Galaxy S20 Ultra)

How to test the changes in this Pull Request:

  1. Ensure your mu-plugins and parent theme are updated on the branches detailed above
  2. Check the homepage, topic landing pages and a single article page

@adamwoodnz adamwoodnz added [Component] Theme Templates, patterns, CSS Redesign labels Sep 5, 2023
@adamwoodnz adamwoodnz added this to the MVP milestone Sep 5, 2023
@adamwoodnz adamwoodnz self-assigned this Sep 5, 2023
@adamwoodnz adamwoodnz changed the title Update local header Update local header layout Sep 5, 2023
@adamwoodnz adamwoodnz force-pushed the update/66-nav-breadcrumbs branch from fbe0e87 to 90a8891 Compare September 5, 2023 03:48
@adamwoodnz adamwoodnz marked this pull request as ready for review September 5, 2023 04:25
@adamwoodnz adamwoodnz requested review from ryelle, a team and StevenDufresne September 5, 2023 04:25
@fcoveram
Copy link

fcoveram commented Sep 5, 2023

It looks great. I just noticed one thing: "Technical guides" link needs to be in the active style (bold font-weight).

On the other hand, I checked the mockups and the Article design misses the breadcrumb. The local header does need to show the breadcrumb when you land in article posts ("Block Directory" in this example).

@adamwoodnz
Copy link
Contributor Author

Updated Screenshots with local nav bar and dynamic nav menu from mu-plugins

Home (with edited content)

Desktop Mobile Mobile nav open
localhost_8888_(Desktop) (3) localhost_8888_(Samsung Galaxy S20 Ultra) (2) localhost_8888_(Samsung Galaxy S20 Ultra) (3)

Topic landing page

Desktop Mobile
localhost_8888_technical-guides_(Desktop) (1) localhost_8888_technical-guides_(Samsung Galaxy S20 Ultra) (1)

/**
* Provide a list of local navigation menus.
*/
function add_site_navigation_menus( $menus ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local navigation menus now defined here, rather than in the mu-plugins block

@adamwoodnz adamwoodnz requested a review from ryelle September 7, 2023 02:54
@adamwoodnz adamwoodnz force-pushed the update/66-nav-breadcrumbs branch from b869495 to caee61e Compare September 7, 2023 23:25
@adamwoodnz
Copy link
Contributor Author

I checked the mockups and the Article design misses the breadcrumb. The local header does need to show the breadcrumb when you land in article posts ("Block Directory" in this example).

Awaiting confirmation before shipping.

@adamwoodnz adamwoodnz added the [Status] Blocked Progress is blocked, possibly by a 3rd party issue label Sep 7, 2023
@jasmussen
Copy link

Francisco is AFK for the moment, so I can only be a silver-medal in terms of feedback.

Notably, I would be okay with shipping this if you all feel it's a strong path forward and not too code-complex. However from gleaning the navigation component that Francisco mocked up here, it isn't clear to me that we are employing it right. From the WP.org design library:

Screenshot 2023-09-11 at 10 53 02
  • The left label should be the section name, i.e. Documentation
  • A label on the right should show the page name, i.e. Technical Guides (elided if need be)
  • There should be a chevron icon on the right, which lines up with the burger menu icon above
  • When the whole bar is opened, I imagined it to open downwards like a dropdown, similar to the News component

News component, closed:

closed

Opened:

open

It can be a modal if need be, we can work with that, but it would be good to get the chevron icon right instead of the "Menu" label at least.

@ryelle
Copy link
Collaborator

ryelle commented Sep 11, 2023

@jasmussen If you want to see how this currently works, it's already in place on the about & download subpages, for example on About > Requirements. The menu could also be on a dark background like on the Download Counter.

A label on the right should show the page name, i.e. Technical Guides (elided if need be)

In the original local header discussion (it's long, relevant comments start here), I shared that the label for the menu should ideally stay consistent throughout the individual site. I think we landed on "menu" by default, but could pick something else.

In any case, since this is a shared component, changing the functionality would need to happen in wporg-mu-plugins. So I'm inclined to let this PR through, and have any follow up design changes to a new issue on that repo.

@adamwoodnz adamwoodnz removed the [Status] Blocked Progress is blocked, possibly by a 3rd party issue label Sep 11, 2023
@adamwoodnz adamwoodnz force-pushed the update/66-nav-breadcrumbs branch from caee61e to 370da8b Compare September 11, 2023 23:11
@adamwoodnz
Copy link
Contributor Author

Updated Screenshots with opacity-white-15 top border color, breadcrumbs back on single and category pages, and charcoal background on mobile nav:

Home (with edited content)

Desktop Mobile Mobile nav open
localhost_8888_(Desktop) (5) localhost_8888_(Samsung Galaxy S20 Ultra) (5) localhost_8888_(Samsung Galaxy S20 Ultra) (6)

Topic landing page

Desktop Mobile
localhost_8888_technical-guides_(Desktop) (3) localhost_8888_technical-guides_(Samsung Galaxy S20 Ultra) (3)

Category page

Desktop Mobile
localhost_8888_category_installation_(Desktop) localhost_8888_category_installation_(Samsung Galaxy S20 Ultra)

Article page

Desktop Mobile
localhost_8888_article_optimization_(Desktop) localhost_8888_article_optimization_(Samsung Galaxy S20 Ultra)

@jasmussen
Copy link

I'm happy to ship and iterate on this one, though I do want to surface that removing the breadcrumbs on one of the subpages was a mistake on my part in the mockups. I may owe an apology.

@adamwoodnz adamwoodnz merged commit b05235a into trunk Sep 13, 2023
@adamwoodnz adamwoodnz deleted the update/66-nav-breadcrumbs branch September 13, 2023 02:32
@adamwoodnz
Copy link
Contributor Author

  • There should be a chevron icon on the right, which lines up with the burger menu icon above

Opened a new issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS Redesign
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Homepage: change type treatment for the large headline at the top of the page
4 participants