Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP Notice: Undefined variable: attending_event_ids #86

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Feb 16, 2024

Stats for new events were not showing and the stats for old events were not updated after making a translation and PHP threw this notice;
PHP Notice: Undefined variable: attending_event_ids. In this PR, the missing $attending_event_ids variable is added.

Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for fixing!

akirk
akirk previously requested changes Feb 16, 2024
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@psrpinto psrpinto dismissed akirk’s stale review February 16, 2024 15:43

Issue has been addressed

@psrpinto psrpinto merged commit 1b22ee9 into trunk Feb 16, 2024
2 checks passed
@psrpinto psrpinto deleted the fix-stat branch February 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants