Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP Notice: Undefined variable: attending_event_ids #86

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Fix PHP Notice: Undefined variable: attending_event_ids #86

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a07e742
Get the array of events user is attending
trymebytes Feb 16, 2024
9ae7586
Add back phpcs comments
trymebytes Feb 16, 2024
5c0752e
Use USER_META_KEY_ATTENDING constant
trymebytes Feb 16, 2024
9611feb
Reduce diff size
akirk Feb 16, 2024
32d2309
Reduce diff size
akirk Feb 16, 2024
1f93e6c
Add WPORG_GP_Translation_Events_Event type hint
trymebytes Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions includes/class-wporg-gp-translation-events-translation-listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,11 @@ function ( $event ) use ( $at ) {
// phpcs:disable Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed
// phpcs:disable Generic.CodeAnalysis.UnusedFunctionParameter.Found
private function select_events_user_is_registered_for( array $events, int $user_id ): array {
$attending_events = get_user_meta( $user_id, 'translation-events-attending', true );
return array_filter(
$events,
function ( $event ) use ( $attending_event_ids ) {
return isset( $attending_event_ids[ $event->ID ] );
function ( $event ) use ( $attending_events ) {
psrpinto marked this conversation as resolved.
Show resolved Hide resolved
return isset( $attending_events[ $event->id() ] );
}
);
}
Expand Down
Loading