Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codex/Planet required bits to header #62

Merged
merged 8 commits into from
Jan 13, 2022
Merged

Add Codex/Planet required bits to header #62

merged 8 commits into from
Jan 13, 2022

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Jan 10, 2022

See #42 & #38

Unfortunately the Codex requires wp4 styles and isn't super pretty with just removing that and dropping in the new header/footer.

as it is with the new header/footer
no_styles

as it is with wp4 sttyles after cc68eb9 - Just adding codex-wp4 didn't help here either.
with_styles

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small things, but overall LGTM 👍🏻

mu-plugins/blocks/global-header-footer/blocks.php Outdated Show resolved Hide resolved
mu-plugins/blocks/global-header-footer/blocks.php Outdated Show resolved Hide resolved
@iandunn
Copy link
Member

iandunn commented Jan 10, 2022

Er, I meant the code looks good, but if the screenshots are current then of course we'll need to do more to fix the styles

@dd32 dd32 force-pushed the add/codex-header branch from 3ceeabb to 96de903 Compare January 13, 2022 02:54
@dd32 dd32 changed the title Add Codex required bits to header Add Codex/Planet required bits to header Jan 13, 2022
bazza pushed a commit to WordPress/wordpress.org that referenced this pull request Jan 13, 2022
… to force the new WordPress global footer below old-theme .wporg-responsive responsive classes.

See WordPress/wporg-mu-plugins#62, WordPress/wporg-mu-plugins#44


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@11436 74240141-8908-4e6f-9713-ba540dce6ec7
@dd32
Copy link
Member Author

dd32 commented Jan 13, 2022

This has ended up with some code that I don't like in it.

https://github.com/WordPress/wporg-mu-plugins/pull/62/files#diff-460e50b82495cab49b3ce3a702572bec919fae2cbec691937f8abbe7de6e2c33R255-R262

As we're loading wordpress.org/wp-json the pub/wporg-main theme is loaded, that brings with it a bunch of styles that don't make sense to load (and break layouts).

There's also this:
https://github.com/WordPress/wporg-mu-plugins/pull/62/files#diff-460e50b82495cab49b3ce3a702572bec919fae2cbec691937f8abbe7de6e2c33R180-R183

it feels like this is uglier than it needs to be, and that maybe we can have these endpoints served by a site with no theme.

@dd32
Copy link
Member Author

dd32 commented Jan 13, 2022

Codex:
screencapture-planet-wordpress-org-Main-Page-2022-01-13-15_34_05
screencapture-planet-wordpress-org-Main-Page-2022-01-13-15_33_49

Planet:
Screen Shot 2022-01-13 at 3 20 06 pm

Screen Shot 2022-01-13 at 3 21 08 pm

@dd32 dd32 merged commit 82f2f1b into trunk Jan 13, 2022
@dd32 dd32 deleted the add/codex-header branch January 13, 2022 06:16
dd32 added a commit that referenced this pull request Jan 13, 2022
@iandunn
Copy link
Member

iandunn commented Jan 13, 2022

have these endpoints served by a site with no theme

That sounds like it could work, if it won't remove some of the scripts/styles that we do want installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants