-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codex/Planet required bits to header #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small things, but overall LGTM 👍🏻
Er, I meant the code looks good, but if the screenshots are current then of course we'll need to do more to fix the styles |
…n the format needed for the codex.
Co-authored-by: Ian Dunn <[email protected]>
3ceeabb
to
96de903
Compare
…don't output the header. This allows for scripts/styles enqueued from within the header to be output within the footer.
… through the rest api.
… to force the new WordPress global footer below old-theme .wporg-responsive responsive classes. See WordPress/wporg-mu-plugins#62, WordPress/wporg-mu-plugins#44 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@11436 74240141-8908-4e6f-9713-ba540dce6ec7
This has ended up with some code that I don't like in it. As we're loading There's also this: it feels like this is uglier than it needs to be, and that maybe we can have these endpoints served by a site with no theme. |
That sounds like it could work, if it won't remove some of the scripts/styles that we do want installed. |
See #42 & #38
Unfortunately the Codex requires wp4 styles and isn't super pretty with just removing that and dropping in the new header/footer.
as it is with the new header/footer
as it is with wp4 sttyles after cc68eb9 - Just adding codex-wp4 didn't help here either.