Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine 404 styles #314

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Refine 404 styles #314

merged 3 commits into from
Feb 15, 2022

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Feb 14, 2022

See #311

Doesn't try to fix these, since they'll be easier to focus on in separate PRs, after this is merged.

  • the negative offset on the "oops" element. I ran into a bunch of weird overflow issues
  • the home-link block empty output. seems like a recent regression, it's happening on trunk, and the cause isn't obvious. maybe related to recent gutenberg release.

Screen Shot 2022-02-15 at 08 55 20-fullpage

Screen Shot 2022-02-15 at 08 56 12-fullpage

@iandunn iandunn self-assigned this Feb 14, 2022
@iandunn iandunn force-pushed the refine-404-styles branch 6 times, most recently from 572b392 to 6d44fc2 Compare February 15, 2022 16:15
@iandunn iandunn marked this pull request as ready for review February 15, 2022 16:57
@iandunn iandunn requested review from ryelle and beafialho February 15, 2022 16:57
@beafialho
Copy link
Collaborator

Thanks @iandunn, I can't see it properly because my testing env is somehow stealing some space below the header, but besides the "Oops" element, the screenshots looks accurate 👍

@ryelle
Copy link
Contributor

ryelle commented Feb 15, 2022

the home-link block empty output. seems like a recent regression, it's happening on trunk, and the cause isn't obvious. maybe related to recent gutenberg release.

I think you're behind on a Gutenberg update, or you've got it deactivated locally.

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, just a few comments, mostly accessibility-adjacent.

Screen Shot 2022-02-15 at 1 06 55 PM

The "homepage" link here should be using var(--wp--preset--color--blue-3);, and the search input could use a focus state (I don't know if there's one designed, @beafialho).

@iandunn
Copy link
Member Author

iandunn commented Feb 15, 2022

I think you're behind on a Gutenberg update, or you've got it deactivated locally.

Ah, you're right, thanks!

I had Git and SVN checkouts of it for various reasons, but accidentally updated it w/ wp-cli, which left the folder empty except for node_modules.

@iandunn iandunn closed this Feb 15, 2022
@iandunn iandunn reopened this Feb 15, 2022
@iandunn
Copy link
Member Author

iandunn commented Feb 15, 2022

I think the only remaining thing is possibly the focus state. I'm going to merge this to make it easier to start on the follow-up PRs, and the focus state can be done in one of those based on Beatriz's feedback.

@iandunn iandunn merged commit 8b373a4 into trunk Feb 15, 2022
@iandunn iandunn deleted the refine-404-styles branch February 15, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants