Replace inf value #232
Merged
Replace inf value #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidszkiba
requested changes
Jan 11, 2024
There was a problem hiding this comment.
There are still other places that reference the max_attempts_per_scale value:
- https://github.com/Wunderbyte-GmbH/moodle-local_catquiz/blob/replace-inf-value/classes/teststrategy/preselect_task/addscalestandarderror.php#L188
- https://github.com/Wunderbyte-GmbH/moodle-local_catquiz/blob/replace-inf-value/classes/teststrategy/preselect_task/addscalestandarderror.php#L191
There, we check how many more questions we could theoretically return from a catscale if we can play at most N questions per scale and already played some or no questions.
I think here we should also include the -1 value in the check:
https://github.com/Wunderbyte-GmbH/moodle-local_catquiz/blob/replace-inf-value/classes/teststrategy/preselect_task/mayberemovescale.php#L65
eynimeni
force-pushed
the
replace-inf-value
branch
from
22fb936
to
454397b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had to change the default inf value because parsing to json isn't supported for INF
does this cause any problems @davidszkiba ?