update to net8.0-rc1 #2044
update to net8.0-rc1 #2044
Conversation
github-actions
bot
added
github_actions
adamsitnik
force-pushed
the
net80update
branch
from
e6c7a31
to
f16b8be
Compare
… easier to change in the future
… net5.0 (out of support) with net6.0 (oldest supported)
…w that targets net8.0
…sure whether it's going to work)
…whether it's going to work)
… am not sure whether it's going to work)" This reverts commit 9e79cc4.
adamsitnik
force-pushed
the
net80update
branch
from
02f9a53
to
1b61baf
Compare
…ot sure whether it's going to work)" This reverts commit 0bbc854.
|
LGTM, we need to resolve some conflicts but is AWESOME @adamsitnik |
# Conflicts: # build/versions.props # src/HealthChecks.NpgSql/HealthChecks.NpgSql.csproj
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 69.06% 67.32% -1.75%
==========================================
Files 179 270 +91
Lines 4613 8761 +4148
Branches 447 632 +185
==========================================
+ Hits 3186 5898 +2712
- Misses 1323 2700 +1377
- Partials 104 163 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Conflicts: # build/versions.props # src/HealthChecks.Network/HealthChecks.Network.csproj
|
@unaizorrilla has approved this PR offline: To make our lives easier I am going to merge it and send a following PR with update to .NET 8 RTM. |
| @@ -5,11 +5,12 @@ | |||
| <PackageTags>$(PackageTags);ArangoDb</PackageTags> | |||
| <Description>HealthChecks.ArangoDb is the health check package for ArangoDb.</Description> | |||
| <VersionPrefix>$(HealthCheckArangoDb)</VersionPrefix> | |||
| <SignAssembly>false</SignAssembly> | |||
There was a problem hiding this comment.
@adamsitnik Did you place here and there <SignAssembly>false</SignAssembly> for such packages only that have unsigned dependencies?
There was a problem hiding this comment.
Did you place here and there false for such packages only that have unsigned dependencies?
Exactly
It should be reverted. It make no sence to require higher TFM in case no specific APIs are used from that TFM. Yes, net5 not supported anymore but this is story about runtime/end-applications but not about libraries. With such change as at picture above you make impossible for net5 apps to use this health check though healthcheck itself works perfectly targeted for net5. |
This PR contains
rc1for all packagesfixes #179