Modify aie2xclbin tool to allow merging kernels in existing XCLBIN #1561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same feature added on the python side by #1508
Tested with iree-amd-aie which as far as I know is the only client of this tool.
I am also assuming that iree-amd-aie will correctly provide unique kernel ids here as the tool doesn't give any warnings if you merge two kernels of same kernel id but then gives incorrect results at runtime.
Here is a WIP PR of how iree-amd-aie will use this. Will clean that PR once we have a wheel from this one.
nod-ai/iree-amd-aie#418