PAASTA-17941: fix topology spread constraint option by using snake_case instead of camelCase #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se instead of camelCase Signed-off-by: Max Falk <[email protected]>
Signed-off-by: Max Falk <[email protected]>
ajayOO8
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, if the Topology Spread Constraints option is set,
setup_kubernetes_jobwill fail because the pod spec kwargtopologySpreadConstraintsis not valid.Solution
Use snake_case
topology_spread_constraintsinstead. Apparently the translation to valid k8s json manifests happens at a later stage.Signed-off-by: Max Falk [email protected]