Move passes out of the passes/pmgen folder #4881
Open
+71
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
added
the
discuss
- Techlib pmgens are now in relevant techlibs/*. - `peepopt` pmgens are now in passes/opt. - `test_pmgen` is still in passes/pmgen. - Update `Makefile.inc` and `.gitignore` file(s) to match new `*_pm.h` location, as well as the `#include`s. - Change default `%_pm.h` make target to `techlibs/%_pm.h` and move it to the top level Makefile. - Update pmgen target to use `$(notdir $*)` (where `$*` is the part of the file name that matched the '%' in the target) instead of `$(subst _pm.h,,$(notdir $@))`.
KrystalDelusion
force-pushed
the
pmgen-pass-restructure
branch
from
837ff82 to
0ec5f1b
Compare
|
Oops I figured out why the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
In the Docs JF while reviewing #4860 it was brought up that architecture specific pmgen passes would be better served in the same folder as the rest of their architecture specific code.
@nakengelhardt suggested making this a separate PR for discussion at Dev JF in case people have any other passes they think should be moved at the same time.
Explain how this is achieved.
Techlib pmgens are now in relevant techlibs/*.
peepoptalso moved and is now in passes/opt.test_pmgenis still in passes/pmgen.If applicable, please suggest to reviewers how they can test the change.