Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Makefile docs/images clean call #4887

Conversation

JasonBrave
Copy link
Contributor

What are the reasons/motivation for this change?

Every time when I run make config-gcc or make clean it would give an error of docs/images directory could not be found.

Explain how this is achieved.

Remove Makefile call to docs/images clean from top level makefile, the new docs/sources/_images clean target would be called by docs Makefile clean target

If applicable, please suggest to reviewers how they can test the change.

Copy link
Member

@KrystalDelusion KrystalDelusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for merge, but I would also note that while the error message is printed, it is ignored by the top level clean target.

@KrystalDelusion KrystalDelusion merged commit 78f27e1 into YosysHQ:main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants