Updates to bugpoint #5068
Open
Updates to bugpoint #5068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
added a commit
that referenced
this pull request
Apr 28, 2025
Move `yosys -h bugpoint` failure into a code-block to break up text. Same for the `exec -expect-return` example. TODOs on #5068 being merged.
Allows checking return value from crashing design. Makes it possible to only accept designs that crash with e.g. SEGFAULT. Based on `exec -expect-return`.
Raise errors from attributes for testing. I want it for bugpoint tests but it could be useful elsewhere.
Add more to help text to describe usage. Add test for no value (should `exit(1)`).
`-greperr <string>` redirects stderr to 'bugpoint-case.err', and then searches that file for `<string>`. Move `-runner` option up with the other options to reduce ambiguity (i.e. so it doesn't look like it's another design parts constraint). Also some shuffling of `err.ys`.
KrystalDelusion
force-pushed
the
krys/bugpoint_fixes
branch
from
804e923 to
2991be2
Compare
Also change `-err_grep` to `-err-grep` for consistency with `-expect-return`.
Allows for adding a suffix to the `bugpoint-case` file name so that multiple `bugpoint`s can run in the same directory, e.g. during a `make test -j4`.
More coverage.
whitequark
approved these changes
May 16, 2025
KrystalDelusion
added a commit
that referenced
this pull request
May 22, 2025
Move `yosys -h bugpoint` failure into a code-block to break up text. Same for the `exec -expect-return` example. TODOs on #5068 being merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
While working on a how-to guide for using
bugpoint(especially in the context of being able to direct people who are making git issues) I ran into a few problems/pain points with the command.Explain how this is achieved.
-wiresflag-expect-returnoption to differentiate e.g. SEGFAULT from other crashes-err-grepoption to check stderr (useful for non-yosys errors)raise_errordev passbugpointtestsIf applicable, please suggest to reviewers how they can test the change.
Run
make makefile-tests/tests/bugpoint.