Make mfp const methods thread-safe.
#5408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, we make the parent links relaxed atomics so concurrent `ifind()` calls are safe. This may appear to cause a tiny performance regression but as discussed in https://yosyshq.discourse.group/t/parallel-optmergepass-implementation/87/16 this is probably just noise.
jix
added
the
merge-after-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
As dsicussed in https://yosyshq.discourse.group/t/parallel-optmergepass-implementation we want to make RTLIL more compatible with multithreaded read-only access, by making access to
constobjects thread-safe.Explain how this is achieved.
We make the parent links relaxed atomics so concurrent
ifind()calls are safe.This may appear to cause a tiny performance regression but as discussed in https://yosyshq.discourse.group/t/parallel-optmergepass-implementation/87/16 this is probably just noise.