Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise timeout duration for Yarn (helps with slow hardware) #397

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

lapineige
Copy link
Member

https://forum.yunohost.org/t/can-not-install-peertube/27740/7

A 30s timeout is too low on many HDD or other slow hardware.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@lapineige
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@lapineige lapineige changed the title Raise timeout duration for Yarn Raise timeout duration for Yarn (helps with slow hardware) Dec 26, 2023
@lapineige lapineige changed the base branch from testing to master December 26, 2023 11:33
@lapineige
Copy link
Member Author

I can confirm that the issue is fixed with this commit.

@lapineige
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🎠
Test Badge

@lapineige
Copy link
Member Author

lapineige commented Dec 26, 2023

But there are other issues : https://paste.yunohost.org/raw/ufasuropar

[domain2.tld:443] 2023-12-26 12:06:34.027 �[31merror�[39m: Cannot install plugin peertube-plugin-auth-ldap, removing it...
There is no plugin table ? 🤔

@lapineige lapineige changed the base branch from master to testing December 26, 2023 14:14
@lapineige
Copy link
Member Author

lapineige commented Dec 26, 2023

So the other issue seems to be related to the LDAP plugin, and not specific to this PR.

As it fixes install issues, according to my testing (CI is failing because of the plugin), I suggest to merge it 🙂

@lapineige
Copy link
Member Author

@lapineige lapineige mentioned this pull request Dec 27, 2023
2 tasks
@lapineige
Copy link
Member Author

#400 should also improve installation on slow hardware.

lapineige added a commit to lapineige/peertube_ynh that referenced this pull request Dec 27, 2023
@lapineige lapineige merged commit c4fa371 into YunoHost-Apps:testing Dec 27, 2023
@lapineige
Copy link
Member Author

I didn't merge it… somehow merging #401 merged this too ??

Well I think this should have been reviewed for approval, as the timing is arbitrary and quite long (5min instead of 30s).
ping @YunoHost-Apps, any opinion ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants