Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd wait for dbinit #400

Merged
merged 8 commits into from
Dec 27, 2023

Conversation

lapineige
Copy link
Member

@lapineige lapineige commented Dec 27, 2023

#397 (comment)

Database isn't initialized completely all the time before using it (LDAP plugin installation), so we should wait for it.

Thanks @alexAubin and @Chocobozzz for you help ! 🙂

Fix #390 #386

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@lapineige
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@lapineige
Copy link
Member Author

Manual testing on a Raspberry Pi 3 + HDD worked (actually it was with #399 but this should be even better). Install on CI is working (failing but as in other current tests).
I believe it should improve installation on slow hardware in particular (where is less likely that the DB is initialized properly before the next install step start).

Ready for review and merge :)

@lapineige
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants