-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Systemd wait for dbinit #400
Merged
lapineige
merged 8 commits into
YunoHost-Apps:testing
from
lapineige:systemd_wait_for_dbinit
Dec 27, 2023
Merged
Systemd wait for dbinit #400
lapineige
merged 8 commits into
YunoHost-Apps:testing
from
lapineige:systemd_wait_for_dbinit
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only on first service start (should be done during the second one)
!testme |
2 tasks
Manual testing on a Raspberry Pi 3 + HDD worked (actually it was with #399 but this should be even better). Install on CI is working (failing but as in other current tests). Ready for review and merge :) |
This was referenced Dec 27, 2023
!testme |
This was referenced Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#397 (comment)
Database isn't initialized completely all the time before using it (LDAP plugin installation), so we should wait for it.
Thanks @alexAubin and @Chocobozzz for you help ! 🙂
Fix #390 #386
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)