Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use the new ZMusic_GetStreamInfoEx #1971

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kcat
Copy link
Contributor

@kcat kcat commented Jan 26, 2023

Updates to use the newer method to get stream info from ZMusic, which provides clearer and less ambiguous format information.

@kcat
Copy link
Contributor Author

kcat commented Jan 26, 2023

Looks like the zmusic.lib files in bin/windows/zmusic/ need to be updated to a newer version. Linux and macOS dynamically grab 1.1.9 releases which seem to work.

@madame-rachelle
Copy link
Collaborator

Looks like the zmusic.lib files in bin/windows/zmusic/ need to be updated to a newer version. Linux and macOS dynamically grab 1.1.9 releases which seem to work.

I was specifically cautioned against this. @coelckers if this is true though, please let me know so I can compile the arm64 one.

@kcat
Copy link
Contributor Author

kcat commented Jan 26, 2023

To clarify in case there's any confusion, I don't necessarily mean to have Windows CI builds pull releases dynamically like Linux and macOS do. Just that a build of 1.1.9 should be sufficient to update the .lib files with (the bin/windows/zmusic/include/zmusic.h header is already updated to a sufficient version with the newer function declarations, while the bin/windows/zmusic/*/zmusic.lib files haven't been updated which makes using what was added in the updated header fail CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants