Added WorldHitscanFired and WorldHitscanPreFired #2432
Conversation
|
Yeah it's hard to pin down the issue with this code since it trips up something else entirely within the new file system. |
|
Report it as a bug. If anything, Graf can take a look at it. |
That's what I'm doing, more or less? I can't really report it as a bug for the current version of GZDoom because this issue occurs only after my personal changes on the cpp side. |
|
@coelckers Looks like it's not something I can solve on my end. Would you be able to debug this? I'm not sure how to progress, because it's not a draft anymore, all the stuff I wanted to add is there, but it's also not really "ready" because it causes a crash in its current form. |
jekyllgrim
changed the title
| @@ -311,6 +311,8 @@ class DStaticEventHandler : public DObject // make it a part of normal GC proces | |||
| void WorldThingRevived(AActor* actor); | |||
| void WorldThingDamaged(AActor* actor, AActor* inflictor, AActor* source, int damage, FName mod, int flags, DAngle angle); | |||
| void WorldThingDestroyed(AActor* actor); | |||
| bool WorldHitscanPreFired(AActor* actor, DAngle angle, double distance, DAngle pitch, int damage, FName damageType, PClassActor *pufftype, int flags, double sz, double offsetforward, double offsetside); | |||
| void WorldHitscanFired(AActor* actor, DVector3 AttackPos, DVector3 DamagePosition, AActor* Inflictor, int flags); | |||
There was a problem hiding this comment.
Make sure to pass vectors by reference value (const DVector3&) to avoid recreating them
src/events.h
Outdated
| double AttackOffsetForward; | ||
| double AttackOffsetSide; | ||
| double AttackZ; | ||
| PClassActor* AttackPuffType; |
There was a problem hiding this comment.
doubles and pointers need default initialization values, otherwise they'll be corrupted
|
This is finally fixed and tested. No performance impact that I could see. |
jekyllgrim
changed the title
This adds
WorldHitscanFiredandWorldHitscanPreFiredevents toP_LineAttackandP_RailAttack. The former is called after a hitscan has been fired and provides information about it; the latter before it and allows stopping it. The idea is to allow mod authors universally detect hitscans, and potentially replace them with projectiles, which hasn't been possible so far.THE PROBLEM is that in its current form, despite compiling properly, it leads to a mysterious crash on startup, presumably tripping up the file system. This is caused by WorldHitscanPrefired specifically; the other features were tested and work fine, but as soon as I added WorldHitscanPrefired, the crashes started happening. Unfortunately, I cannot nail down the issue myself.UPD: I can't believe my inattention; the whole problem was that WorldHitscanPreFired was defined without a return value in zscript, and apparently that causes a CTD on startup rather than a build error.
Test file. This replaces hitscans with plasma balls and reports on received values.
WorldHitscan.zip