-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtraDepletionBehavior #2615
Open
XLightningStormL
wants to merge
9
commits into
ZDoom:master
Choose a base branch
from
XLightningStormL:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ExtraDepletionBehavior #2615
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
038caf3
Update inventory_util.zs
XLightningStormL 6169c0f
Update inventory.zs
XLightningStormL 282c1ef
Update inventory_util.zs
XLightningStormL 6e2120c
Replaced ExtraDepletion with DepleteBy Logic
XLightningStormL 8224828
Replaced ExtraDepletion with DepleteBy Logic
XLightningStormL 2626c73
Update inventory_util.zs
XLightningStormL 2c6d46c
Update inventory.zs
XLightningStormL 8efb001
Update inventory_util.zs
XLightningStormL 85edffc
Update inventory.zs
XLightningStormL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -146,11 +146,7 @@ extend class Actor | |
|
||
if (!fromdecorate) | ||
{ | ||
item.Amount -= amount; | ||
if (item.Amount <= 0) | ||
{ | ||
item.DepleteOrDestroy(); | ||
} | ||
item.DepleteBy(amount); | ||
// It won't be used in non-decorate context, so return false here | ||
return false; | ||
} | ||
|
@@ -163,17 +159,18 @@ extend class Actor | |
|
||
// Do not take ammo if the "no take infinite/take as ammo depletion" flag is set | ||
// and infinite ammo is on | ||
// Alternatively do not take customInventory items if sv_infiniteinventory is true | ||
if (notakeinfinite && | ||
(sv_infiniteammo || (player && FindInventory('PowerInfiniteAmmo', true))) && (item is 'Ammo')) | ||
(sv_infiniteammo || (player && FindInventory('PowerInfiniteAmmo', true))) && (item is 'Ammo') | ||
|| sv_infiniteinventory && item is 'CustomInventory') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was wrong. TakeInventory is never called if sv_infiniteinventory is true, so this part alone should be reverted. Otherwise this could cause some problems. Sorry about that. |
||
{ | ||
// Nothing to do here, except maybe res = false;? Would it make sense? | ||
result = false; | ||
} | ||
else if (!amount || amount >= item.Amount) | ||
else | ||
{ | ||
item.DepleteOrDestroy(); | ||
item.DepleteBy(amount); | ||
} | ||
else item.Amount -= amount; | ||
|
||
return result; | ||
} | ||
|
@@ -271,10 +268,9 @@ extend class Actor | |
{ | ||
return true; | ||
} | ||
|
||
if (--item.Amount <= 0) | ||
else | ||
{ | ||
item.DepleteOrDestroy (); | ||
item.DepleteBy(1); //useinventory can only really use one item at a time | ||
} | ||
return true; | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check here should be
amount < 1
, not!amount
.amount
is an integer and it can be negative.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both changes pushed now.