Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- enable mipmapping in 2D #2809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madame-rachelle
Copy link
Collaborator

This commit is already in VkDoom and has been for a few months. If this is not to be allowed though - I have to ask, why? What was the decision that led to disabling 2D mipmapping?

@RicardoLuis0
Copy link
Collaborator

IIRC in some intel GPUs, mipmapping being enabled forces texture filtering on, not sure if that's why

@madame-rachelle
Copy link
Collaborator Author

If that's the case shouldn't the "fix" target Intel GPU's only?

Also - does that still happen in Vulkan? I wouldn't be surprised if it's OpenGL only considering Intel's OpenGL driver has a lot of weird quirks like that.

@RicardoLuis0
Copy link
Collaborator

pretty sure it does in vulkan too yeah, idk about the specifics though, just going off of memory

@RicardoLuis0
Copy link
Collaborator

yep vulkan too, seems like it's only for anisotropic filtered mipmaps, not mipmaps in general though #2679

@madame-rachelle
Copy link
Collaborator Author

Well in that case then it's an Intel problem. I am not sure if the majority of users who do not use Intel should be punished with worse looking 2D just because one vendor can't handle their anisotropic mipmaps. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants