Updating from PR #13
Closed
Updating from PR #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendrell46
reviewed
Jan 13, 2025
| @@ -119,28 +119,34 @@ contract LM_ManualExternalPriceSetter_v1 is | |||
| // ------------------------------------------------------------------------- | |||
| // External Functions | |||
|
|
|||
| /// @notice Internal function to set the issuance price | |||
| /// @param price_ The price to set | |||
| function _setIssuancePrice(uint price_) internal { | |||
There was a problem hiding this comment.
these two functions seem to be under // External Functions
vendrell46
reviewed
Jan 14, 2025
| @@ -578,7 +578,7 @@ contract FM_PC_ExternalPrice_Redeeming_v1 is | |||
|
|
|||
| // Create and emit the order. | |||
| _createAndEmitOrder( | |||
| _receiver, _depositAmount, collateralRedeemAmount, issuanceFeeAmount | |||
| _receiver, _depositAmount, collateralRedeemAmount, projectFeeAmount | |||
There was a problem hiding this comment.
what was the reason for this change? just curious
There was a problem hiding this comment.
This was from the audit check here
vendrell46
reviewed
Jan 14, 2025
There was a problem hiding this comment.
I guess we can delete the file if we don't need it anymore
vendrell46
reviewed
Jan 14, 2025
There was a problem hiding this comment.
I guess we can delete the file if we don't need it anymore
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Refactor FM_PC_ExternalPrice_Redeeming_v1
Changes:
Testing: