-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Removed the logic that conditionally hides the mark_horizontal_lines
field
#1075
Open
tahierhussain
wants to merge
5
commits into
main
Choose a base branch
from
fix/avoid-conditionally-hiding-the-mark-horizontal-lines-field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FIX: Removed the logic that conditionally hides the mark_horizontal_lines
field
#1075
tahierhussain
wants to merge
5
commits into
main
from
fix/avoid-conditionally-hiding-the-mark-horizontal-lines-field
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahierhussain
requested review from
jagadeeswaran-zipstack,
johnyrahul,
vishnuszipstack and
hari-kuriakose
January 17, 2025 11:32
johnyrahul
approved these changes
Jan 20, 2025
…zontal-lines-field
…zontal-lines-field
jagadeeswaran-zipstack
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…zontal-lines-field
|
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
mark_horizontal_lines
field whenmark_vertical_lines
isfalse
.Why
The previous logic caused a UX issue where users couldn't uncheck the
mark_horizontal_lines
field after it was hidden, despite its value remainingtrue
. This led to unexpected errors, as the value was still being passed to the backend.How
mark_horizontal_lines
field.danger
type for better visibility and clarity.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No. The changes in this PR are very minimal and the chances of this breaking any existing features is very low.
Database Migrations
NA
Env Config
NA
Relevant Docs
NA
Related Issues or PRs
NA
Dependencies Versions
NA
Notes on Testing
NA
Screenshots
Checklist
I have read and understood the Contribution Guidelines.