Fix escaping in JSON schema patterns #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The escaping logic for patterns in JSON schema got convoluted, and we introduced inadvertently inconcistencies in the formatting. Namely, we first *unescaped* all the characters before passing them into the parser for regular expressions. This unescaped characters later propagated and mixed with *escaped* characters when the expression was transpiled for UTF-16. To solve this mess, we remove the unescaping step at the beginning and test more thouroughly to specify & observe the expected behavior.
mristin
force-pushed
the
mristin/Fix-escaping-in-JSON-schema-patterns
branch
from
01cde4d to
d665440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The escaping logic for patterns in JSON schema got convoluted, and we introduced inadvertently inconcistencies in the formatting. Namely, we first unescaped all the characters before passing them into the parser for regular expressions. This unescaped characters later propagated and mixed with escaped characters when the expression was transpiled for UTF-16.
To solve this mess, we remove the unescaping step at the beginning and test more thouroughly to specify & observe the expected behavior.
Fixes #485.