Add choices for concrete classes in Protobuf #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add additional choice classes corresponding to concrete classes with concrete descendants in Protobuf. So far, we omitted this case as the concrete classes with concrete descendants do not appear in the AAS meta-models. However, we decide to make the implementation future-proof in that regard as it is very possible that in the near future we do face concrete classes with descendants in properties.
mristin
deleted the
mristin/Fix-protobuf-for-concrete-classes-with-descendants
branch
mristin
pushed a commit
that referenced
this pull request
Oct 28, 2024
In #531 the `_choice` suffix has been introduced for concrete types with concrete classes as subtypes. Since Protobuf does not support inheritance, this was necessary so that we can distinguish between the concrete class and a choice (union) class with quasi-polymorphism. For the sake of consistency, this suffix shall be used for all types that have concrete descendants, *i.e.* for all the choice (union) classes, including the abstract classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add additional choice classes corresponding to concrete classes with concrete descendants in Protobuf.
So far, we omitted this case as the concrete classes with concrete descendants do not appear in the AAS meta-models. However, we decide to make the implementation future-proof in that regard as it is very possible that in the near future we do face concrete classes with descendants in properties.