Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time function implementation #310

Merged
merged 25 commits into from
Feb 25, 2022
Merged

Time function implementation #310

merged 25 commits into from
Feb 25, 2022

Conversation

ikurek
Copy link
Contributor

@ikurek ikurek commented Feb 2, 2022 •
edited
Loading

This is a rework of #282 because the previous PR was made from enhancement/formatting and the branch can't be merged. The logic stays the same, I only rebased it on main branch and resolved file conflicts

@ikurek ikurek mentioned this pull request Feb 2, 2022
Closed
@github-actions github-actions bot temporarily deployed to staging/pull/310/dartdoc February 2, 2022 16:12 Inactive
ikbalkaya
ikbalkaya approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ikurek ikurek force-pushed the feature/time-function branch from 37ebf95 to 650f395 Compare February 2, 2022 16:14
@github-actions github-actions bot temporarily deployed to staging/pull/310/dartdoc February 2, 2022 16:17 Inactive
@ikurek ikurek self-assigned this Feb 4, 2022
@ikurek ikurek added the enhancement New feature or improved functionality. label Feb 7, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/310/dartdoc February 8, 2022 11:59 Inactive
@ikurek ikurek force-pushed the feature/time-function branch from f29528d to 38df5e5 Compare February 8, 2022 17:21
@github-actions github-actions bot temporarily deployed to staging/pull/310/dartdoc February 8, 2022 17:24 Inactive
@ikurek ikurek requested a review from ikbalkaya February 8, 2022 17:43
@ikurek
Copy link
Contributor Author

ikurek commented Feb 8, 2022

I've implemented some additional changes for iOS, because restTime method handler wasn't registered correctly: 38df5e5

@ikurek ikurek linked an issue Feb 9, 2022 that may be closed by this pull request
Implement stats Rest and Realtime clients #260
Closed
@ikbalkaya ikbalkaya mentioned this pull request Feb 10, 2022
Closed
ikbalkaya
ikbalkaya approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikurek
Copy link
Contributor Author

ikurek commented Feb 14, 2022 •
edited
Loading

@ikbalkaya I've implemented integration tests for time function in 00da9dd and 7d36455

@github-actions github-actions bot temporarily deployed to staging/pull/310/dartdoc February 14, 2022 12:45 Inactive
@ikurek ikurek force-pushed the feature/time-function branch from 11b48f2 to 7d36455 Compare February 14, 2022 17:06
@github-actions github-actions bot temporarily deployed to staging/pull/310/dartdoc February 14, 2022 17:09 Inactive
ikbalkaya and others added 18 commits February 25, 2022 14:16
@ikbalkaya @ikurek
Renamed method to time in Java
d275c54
@ikbalkaya @ikurek
Updated refercen name to _time
d2b235a
@ikbalkaya @ikurek
Implemented time function in rest.dart
5bf0bcb
@ikbalkaya @ikurek
Added rest time to UI
a622501
@ikbalkaya @ikurek
Used getAblyClient to get the rest instance
e490917
@ikbalkaya @ikurek
Add code to be able to switch between rest/realtime for objective-c code
9eb797e
@ikbalkaya @ikurek
Code formatting
2e9c372
@ikbalkaya @ikurek
Code formatting for rest.dart and realtime.dart
4110d29
@ikbalkaya @ikurek
Made explicit differences between restTime and realtimeTime
ace3527
@ikbalkaya @ikurek
Split realtimeTime and restTime in two methods Android id side
2f29832
@ikbalkaya @ikurek
Split realtimeTime and restTime in two methods iOSside
796b1c0
@ikbalkaya @ikurek
Flutter format
0aaed28
@ikurek
Regenerated platform constants for time function
68c467e
@ikurek
Fixed time methods code smells, added missing AblyBase import
8bd0215
@ikurek
Fixed restTime method message handling on iOS side
4004ace
@ikurek
Added integration test for rest time function
5fdb3bc
@ikurek
Added integration test for realtime time function
37e3e85
@ikurek
Linked Github issue #179 with FIXME marker in PlatformObject class
039c78c
@ikurek ikurek force-pushed the feature/time-function branch from 7d36455 to 039c78c Compare February 25, 2022 13:16
@ikurek ikurek merged commit 595e92e into main Feb 25, 2022
@ikurek ikurek deleted the feature/time-function branch February 25, 2022 13:40
@ikurek ikurek mentioned this pull request Feb 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikbalkaya ikbalkaya ikbalkaya approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees

@ikurek ikurek

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement stats Rest and Realtime clients
3 participants
@ikurek @ikbalkaya @QuintinWillison