Fix parsing of semver according to official specification #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrisco
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Thanks! Do you think you could add some kind of regression testing for this? Maybe a unit test on the packager.go or perhaps an integration test where a package is built that has some crazy version that requires the full extent of this regex pattern? I would hate to break this in a future change 😅
|
I'll write some tests, just need to learn Go for this :D |
|
I've gone and merged #82 which should fix this issue, thank you for the pull request and sorry for any delays here 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Build Metadata it should be possible to use '+' sign to annotate version with build metadata.
However, the regex packager.go:500 doesn't allow that.
Using this string as a chart version will fail: 0.0.9+63-gf336c00.