Improve mobile styles for the subscription dialog #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improve mobile styles for the subscription dialog. Previsouly, for mobile phones in landscape mode, the modal was cut off with no scroll bar:
Screencast.from.26-10-2023.19.11.40.webm
Now, a scroll bar is shown and the content is no longer cut off:
Screencast.from.26-10-2023.19.10.40.webm
Related Issue(s):
(none)
Changes Included:
Implementation Details:
Used the following:
safe
keyword will notcenter
the content, but display it asflex-start
(meaning there's no cutting off / data loss)Testing:
We can try to emulate landscape on the browser, and checking out the newsletter subscription dialog
Checklist: