Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile styles for the subscription dialog #214

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Improve mobile styles for the subscription dialog #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c94de2
fix: improve mobile styles for the subscription dialog
jongomez Oct 26, 2023
fa7af9c
fix: remove rogue empty line
jongomez Oct 26, 2023
b9c1275
fix: increate margin bottom for buttons in sub dialog
jongomez Oct 26, 2023
b97c4c1
fix: fix styles for the info message boxes
jongomez Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/FullscreenDialog/FullscreenDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ const MainContentContainer = styled.div`
display: flex;
flex-direction: column;
align-items: center;
/* safe center will center for large screens, but still show a scroll bar for smaller screens */
justify-content: safe center;

overflow: auto;
height: 100%;

padding: 24px 0;
width: 430px;
Expand Down
18 changes: 13 additions & 5 deletions src/components/NewsletterSubscriptionForm/NewsletterSubscriptionForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export default function NewsletterSubscriptionForm({
{successMessage}
</SubmitionInfoMessage>
</MessageContainer>
<ToHomePageButton variant="filled" onClick={onClose}>
<GoBackButton variant="filled" onClick={onClose}>
Go back
</ToHomePageButton>
</GoBackButton>
</>
)}

Expand Down Expand Up @@ -92,14 +92,17 @@ export default function NewsletterSubscriptionForm({
)
}

const ToHomePageButton = styled(Button)`
const GoBackButton = styled(Button)`
margin-top: 46px;
margin-bottom: 60px;
height: 40px;
width: 162px;
color: rgb(var(--lsd-text-secondary));
`

const MessageContainer = styled.div`
box-sizing: border-box;

display: flex;
align-items: center;

Expand All @@ -109,8 +112,11 @@ const MessageContainer = styled.div`
margin-bottom: -6px;
margin-top: 40px;

width: 430px;
max-width: 93%;
width: 100%;

svg {
flex-shrink: 0;
}
`

const SubmitionInfoMessage = styled(Typography)`
Expand All @@ -128,6 +134,8 @@ const EmailSubscribeForm = styled.form<{
gap: 16px;
width: 100%;
margin-top: 50px;

margin-bottom: 60px;
`

const StyledTextField = styled(TextField)`
Expand Down
3 changes: 2 additions & 1 deletion src/containers/NewsletterSubscriptionDialog/NewsletterSubscriptionDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,6 @@ const LogosIconAndTitleContainer = styled.div`
display: flex;
align-items: center;
gap: 16px;
margin-bottom: 16px;

margin: 16px 0;
`
Loading