background lanterns 404 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
exitcy
commented
Jan 27, 2025
•
exitcy
commented
This comment was marked as spam.
This comment was marked as spam.
stanleylew5
requested changes
Jan 27, 2025
src/components/404Lanterns.tsx
Outdated
| <Image | ||
| src={Lantern} | ||
| alt="Lantern background" | ||
| className="w-70 absolute right-20 top-28" |
There was a problem hiding this comment.
use vw/vh units instead of 20, 28, 70 for width and right/top values. I'll have you merge this code into brenda's once I merge her pr in
…tcy/backgroundlanterns
pull from dev
…tcy/backgroundlanterns
|
|
|
|
stanleylew5
requested changes
Jan 28, 2025
src/components/NotFound.tsx
Outdated
Comment on lines
11
to
16
| style={{ | ||
| width: "40.40vw", | ||
| right: "11vw", | ||
| top: "0vh", | ||
| zIndex: 0, | ||
| }} |
src/components/NotFound.tsx
Outdated
| </p> | ||
| <p | ||
| className="font-lora text-[2.5vw] text-csa-gray-100" | ||
| style={{ zIndex: 10 }} |
src/components/NotFound.tsx
Outdated
| /> | ||
| <p | ||
| className="text-[12vw] font-bold text-csa-yellow-300" | ||
| style={{ zIndex: 10 }} |
There was a problem hiding this comment.
the image seems to be uneven in terms of the lantern strings so crop the top of the photo and reupload it to the repo
src/app/not-found.tsx
Outdated
Comment on lines
4
to
8
| return ( | ||
| <div className="notfound-container"> | ||
| <NotFound /> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
go back to what it originally was
|
|
stanleylew5
requested changes
Jan 30, 2025
src/components/NotFound.tsx
Outdated
Comment on lines
15
to
19
| style={{ | ||
| width: "35.18vw", | ||
| right: "11vw", | ||
| top: "0vh", | ||
| }} |
There was a problem hiding this comment.
tailwindcss can be used for these parts too
src/components/NotFound.tsx
Outdated
| <Image | ||
| src={Lantern} | ||
| alt="Lantern background" | ||
| className="absolute z-0 opacity-100" |
There was a problem hiding this comment.
add in h-screen, the lantern height varies on different screens right now
…tcy/backgroundlanterns
stanleylew5
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.