Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background lanterns 404 #70

Merged
merged 15 commits into from
Jan 31, 2025
Binary file added public/notfound/lantern404.webp
Binary file not shown.
9 changes: 8 additions & 1 deletion src/app/not-found.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
import Lantern from "@/components/404Lanterns";

const NotFound = () => {
return <div>404 Page Not Found</div>;
return (
<div>
404 Page Not Found
<Lantern />
</div>
);
};

export default NotFound;
17 changes: 17 additions & 0 deletions src/components/404Lanterns.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from "react";
import Image from "next/image";
import Lantern from "@/public/notfound/lantern404.webp";

const LanternBackground = () => {
return (
<div>
<Image
src={Lantern}
alt="Lantern background"
className="w-70 absolute right-20 top-28"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use vw/vh units instead of 20, 28, 70 for width and right/top values. I'll have you merge this code into brenda's once I merge her pr in

/>
</div>
);
};

export default LanternBackground;
Loading