2 Bugfixes of dns_dynv6.sh: 1. domains containing 'id' are now working as intended and 2. hostnames are now cast to lowercase on the fly
#5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e string 'id' dns_dynv6.sh This will now search for `"id:"` instead of `id` and therefore will only find the id field and not any other field containing the sub-string 'id'
… upper case characters would not be accepted (dynv6 API rejects those). Now the fulldomain will be cast to lowercase first which should not make any difference since DNS is case insensitive.
…mply with requested standards. This does not change any functionality in this special case but the request for [:upper:] and [:lower:] makes a lot of sense in general.
|
Welcome |
|
The unit tests / github actions requested for a DNS-API run without errors. Thanks for building and maintaining such a great tool! |
Neilpang
reviewed
Jul 23, 2024
| fulldomain=$1 | ||
| txtvalue=$2 | ||
| fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]') | ||
| txtvalue="$2" |
There was a problem hiding this comment.
Sorry I overlooked the existence of that function but this is changed now.
Also thanks for the quick response!
`_lower_case` which is already provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idto get the id of the provided zone. This was changed to find"id":to only get this field.