Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 Bugfixes of dns_dynv6.sh: 1. domains containing 'id' are now working as intended and 2. hostnames are now cast to lowercase on the fly #5218

Merged
merged 5 commits into from
Sep 15, 2024
Merged

2 Bugfixes of dns_dynv6.sh: 1. domains containing 'id' are now working as intended and 2. hostnames are now cast to lowercase on the fly #5218

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5789e80
Fixed a bug where the zone_id was corrupted for domains containing th…
IIIPr0t0typ3III Jul 5, 2024
a2bc79d
Fixed a bug where trying to add entries where the fulldomain contains…
Jul 7, 2024
ab86e05
Changed A-Z and a-z to [:upper:] and [:lower:] from last commit to co…
Jul 7, 2024
0a64567
Merge branch 'acmesh-official:dev' into dev
IIIPr0t0typ3III Jul 22, 2024
dd582c0
Changed the direct call of `tr` to cast to lower case to the function
Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dnsapi/dns_dynv6.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ dynv6_api="https://dynv6.com/api/v2"
# Please Read this guide first: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide
#Usage: dns_dynv6_add _acme-challenge.www.domain.com "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
dns_dynv6_add() {
fulldomain=$1
txtvalue=$2
fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]')
txtvalue="$2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use _lower_case()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I overlooked the existence of that function but this is changed now.

Also thanks for the quick response!

_info "Using dynv6 api"
_debug fulldomain "$fulldomain"
_debug txtvalue "$txtvalue"
Expand Down Expand Up @@ -50,8 +50,8 @@ dns_dynv6_add() {
#Usage: fulldomain txtvalue
#Remove the txt record after validation.
dns_dynv6_rm() {
fulldomain=$1
txtvalue=$2
fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]')
txtvalue="$2"
_info "Using dynv6 API"
_debug fulldomain "$fulldomain"
_debug txtvalue "$txtvalue"
Expand Down Expand Up @@ -206,7 +206,7 @@ _get_zone_id() {
return 1
fi

zone_id="$(echo "$response" | tr '}' '\n' | grep "$selected" | tr ',' '\n' | grep id | tr -d '"')"
zone_id="$(echo "$response" | tr '}' '\n' | grep "$selected" | tr ',' '\n' | grep '"id":' | tr -d '"')"
_zone_id="${zone_id#id:}"
_debug "zone id: $_zone_id"
}
Expand Down
Loading