feat: add environment variables to configure monitoring in Docker image #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
|
I also need to set |
jjoyce0510
approved these changes
Jul 1, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that the CLI of datahub-actions contains an option to enable a monitoring endpoint - this PR introduces two new environment variables (DATAHUB_ACTIONS_MONITORING_ENABLED and DATAHUB_ACTIONS_MONITORING_PORT) which allows to enable this endpoint when running the Docker image.
There will be a second PR for the datahub-helm repository which will make use of these two environment variables.
edit: Here is the other PR: acryldata/datahub-helm#473