Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monitoring configuration to acryl-datahub-actions subchart #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Masterchen09
Copy link
Contributor

@Masterchen09 Masterchen09 commented Jun 7, 2024

This PR enables the monitoring endpoint for the acryl-datahub-actions deployment using a new environment variable (see here: acryldata/datahub-actions#118) in case monitoring is enabled globally.

This PR should not be merged until the other PR in the datahub-actions repository has been merged and version v0.0.17 of the image is available.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link

github-actions bot commented Jul 9, 2024

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Jul 9, 2024
@sgomezvillamor
Copy link
Contributor

+1 I'm also interested on this!

@github-actions github-actions bot removed the stale label Jul 10, 2024
@Masterchen09 Masterchen09 force-pushed the feat-datahub-actions-monitoring branch from 2bd2e47 to 99d94bb Compare July 13, 2024 13:03
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Aug 13, 2024
@Masterchen09
Copy link
Contributor Author

To make sure that this PR is not automatically closed - here’s a comment.

@github-actions github-actions bot removed the stale label Aug 14, 2024
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants