Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dvas integration 2023 #209

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Dvas integration 2023 #209

merged 4 commits into from
Oct 16, 2023

Conversation

tukiains
Copy link
Contributor

@tukiains tukiains commented Oct 16, 2023

This PR:

  • Adds dvasUpdatedAt property to product metadata
  • Adds dvasUpdated = true / false parameter to /api/files/ and /api/model-files/ routes
  • Uses new dvasId site identifiers

Needs https://github.com/actris-cloudnet/dataportal-resources/tree/dvas-integration-2023 to work

@tukiains tukiains force-pushed the dvas-integration-2023 branch from 1e3ce5c to 78141a0 Compare October 16, 2023 05:03
Add `dvasUpdatedAt` property to metadata and `dvasUpdated` parameter to routes
@tukiains tukiains force-pushed the dvas-integration-2023 branch from 78141a0 to 33e1771 Compare October 16, 2023 05:08
@tukiains tukiains marked this pull request as ready for review October 16, 2023 06:41
@tukiains tukiains requested a review from siiptuo October 16, 2023 06:47
Copy link
Contributor

@siiptuo siiptuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pari ehdotusta, mutta voi vapaasti mergetä sellaisenaan!

title="Definition for the variable in ACTRIS vocabulary"
class="tag"
v-if="linkToVocabulary && currentData.productVariable.actrisVocabUri"
v-if="linkToVocabulary && currentData.productVariable.actrisName"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pikkuisen duplikointia. Halutessa voisi tehdä dvasVocabUri computed propertyn.

backend/fixtures/3-product_variable.json Outdated Show resolved Hide resolved
backend/src/entity/File.ts Outdated Show resolved Hide resolved
@tukiains tukiains merged commit d101617 into main Oct 16, 2023
@tukiains tukiains deleted the dvas-integration-2023 branch October 16, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants