Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BANKS_WITH_LIMITED_HISTORY constant and Implement BANKINTER_BKBKESMM Bank Adapter #355

Merged
merged 5 commits into from
May 16, 2024

Conversation

hostyn
Copy link
Contributor

@hostyn hostyn commented May 9, 2024

This PR fixes #354 by introducing a new optional property, overwriteMaxHistoricalDays, to the IBank interface. The purpose of this property is to allow users to specify a custom max_historical_days value for banks affected by the 90-day limitation.

It also adds the BANKINTER_BKBKESMM bank adapter.

@MatissJanis
Copy link
Member

👋 Thanks for working on this. Instead of applying this patch to just a single bank - I think we should apply it to all the banks in the list. Would you mind looking into that?

Ideally we shouldn't need to create a separate bank adapter for each of these banks. We could just have a single long list of regular expressions for these banks. And if a bank on the list matches - apply 90 as the max (if institution.transaction_total_days > 90)

@hostyn hostyn changed the title Add overwriteMaxHistoricalDays Property to IBank Interface and Implement BANKINTER_BKBKESMM Bank Adapter Add BANKS_WITH_LIMITED_HISTORY constant and Implement BANKINTER_BKBKESMM Bank Adapter May 9, 2024
@hostyn
Copy link
Contributor Author

hostyn commented May 9, 2024

You are right, I added the changes and updated the title.

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review labels May 16, 2024
@MatissJanis MatissJanis merged commit c51e636 into actualbudget:master May 16, 2024
6 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 16, 2024
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with max_historical_days for Bankinter (BANKINTER_BKBKESMM)
2 participants