Add gocardless support for Berliner Sparkasse (Germany) #358
Conversation
changed calculateStartingBalance
revert calculateStartingBalance to original
| }, | ||
|
|
||
| sortTransactions(transactions = []) { | ||
| return sortByBookingDateOrValueDate(transactions); |
There was a problem hiding this comment.
This seems like the default case. Could you import and use the fallback version instead?
See this file for an example: https://github.com/actualbudget/actual-server/blob/master/src/app-gocardless/banks/belfius_gkccbebb.js
There was a problem hiding this comment.
Can you add a test case? See https://github.com/actualbudget/actual-server/blob/master/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js for an example.
changed to fallback version for sortTransactions as requested by reviewer
|
Be sure to update this file too: https://github.com/actualbudget/actual-server/blob/master/src/app-gocardless/tests/bank-factory.spec.js |
|
Actually hold off on modifying the test for bank factory. #367 should make that no longer necessary. |
|
Thanks for working on this! Would you mind updating the PR to use prop spreading for We recently merged some changes to simplify them. Happy to merge this PR once that's done + the conflict is solved! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Sorry for being inactive this last month. I'll be back home this weekend and will pick this up. |
I have updated this PR to include the requested changes and resolved the mentioned conflict. Any chance this can be included in the upcoming update still? |
No worries, I knew I was late for the release. |
|
@Peccadilloz do you think I can just add the ID for Mittelbrandenburgische Sparkasse and it'll work? 🤔 |
|
I am also having the same trouble with my bank. It is the Rheinhessen Sparkasse (that is the official name), the name under GoCardless was: Sparkasse Worms-Alzey-Ried (BIC: MALADE51WOR). |
Similar to PR #346 this adds a gocardless formatter to properly format transaction information. The additional remittance information was not picked up by actual as this bank transmits it as remittanceInformationStructured instead of remittanceInformationUnstructured.
I have tested this successfully with my bank. The "Notes" section is now being filled with the additional remittance information.
This fixes my original issue in the actual repo #2759