Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(thanos): make fail #1073

Merged
merged 6 commits into from
Jul 21, 2023
Merged

chore(thanos): make fail #1073

merged 6 commits into from
Jul 21, 2023

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented Jul 20, 2023

Description

Make Thanos templating Fail

According to docs/argocd-app-of-apps.md:

We will still keep the app available in the app-of-apps chart for at least 6 months so users can take time to replace it. During this time the component does not get regular updates unless there are egregious security issues that need addressing.
Once we are ready to fully remove it we replace the components template with a fail template:

The PR 854 keeping the app with just a DEPRECATION notice is from 8 months ago. So we make it fail now and wait for a year.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

Signed-off-by: Toni Tauro <[email protected]>
@eyenx eyenx requested a review from a team as a code owner July 20, 2023 09:11
@eyenx eyenx requested review from hairmare and tongpu July 20, 2023 09:11
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2023
docs/argocd-app-of-apps.md Outdated Show resolved Hide resolved
@eyenx eyenx requested a review from tongpu July 20, 2023 11:39
@eyenx eyenx merged commit 355cb54 into main Jul 21, 2023
3 checks passed
@eyenx eyenx deleted the chore/make-thanos-chart-fail branch July 21, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants