[dev 4.0.1 -> staging] Add namespace support for Android #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add conditional namespace to support gradle 8 * Use git as pub resource * Revert "Use git as pub resource" This reverts commit 027911d. * fix * fix * fix * Revert "fix" This reverts commit 2a5a804. * Revert "fix" This reverts commit fbee65b. * Revert "fix" This reverts commit 746c0ca. * Revert "Revert "Use git as pub resource"" This reverts commit 4b7485e. * Revert "Use git as pub resource" This reverts commit 027911d.
…s and Update issue_template (#106) * bump the major version to 4.0.0 (to include Android SDK 3.0.0 and iOS SDK 5.0.0) * specify the ios version * update CI to use Xcode 15.0.1 * fix CI syntax issue * draft * cleanup * update API doc * address review comments * address a review comment * correct timeout accuracy * Update FlutterAEPCorePlugin.m * feat: ⬆️ messaging api changes * Update EdgeBridge sample app and readme Update EdgeBridge sample app and readme * refactor: ♻️ rename edge event type for messaging * chore: reenable messaging * fix: 🐛 fixes for messaging * disable unit tests * docs: 📝 remove beta language from messaging docs * Update README for Privacy Manifest changes (#100) * update main README to show information about "Privacy Manifest" * fix: 🐛 fix oncontentloaded to be android only * Update Flutter version for the plugins, update sample app gradle files and update issue_template Update Flutter version for the plugins Update sample app gradle files Update issue_template --------- Co-authored-by: yansong <[email protected]> Co-authored-by: dsoffiantini <[email protected]>
update ci java-version
cacheung
requested review from
yangyansong-adbe,
dsoffiantini,
PravinPK,
praveek and
cdhoffmann
and removed request for
PravinPK
|
@cacheung |
remove and gitignore pubspec.lock in the plugins
* update issue template description update issue template description * update bug_report.yml update bug_report.yml
yangyansong-adbe
approved these changes
Apr 23, 2024
cdhoffmann
requested changes
Apr 23, 2024
.github/workflows/dart.yml
Outdated
| @@ -44,14 +44,14 @@ jobs: | |||
|
|
|||
| - uses: maxim-lobanov/setup-xcode@v1 | |||
| with: | |||
| xcode-version: "15.0.1" | |||
| xcode-version: "15.2" | |||
There was a problem hiding this comment.
why are we changing this? We should build on the earliest version we support.
There was a problem hiding this comment.
Need to update the versions for all the plugins to 3
Update android project gradle version
migration doc update
dsoffiantini
approved these changes
Apr 23, 2024
cdhoffmann
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: