Skip to content

chore: fix overlay positioning #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

chore: fix overlay positioning #8848

merged 5 commits into from
Oct 20, 2025
+169 −64

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Sep 11, 2025 •
edited
Loading

In collaboration with @LFDanLu

Closes #2874

Closes #7960

Verify on nightly: #7897, #6333

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 11, 2025

Build successful! 🎉

@LFDanLu LFDanLu changed the base branch from revert-overlay-positioning to main September 11, 2025 17:07
@snowystinger snowystinger force-pushed the fix-overlay-positioning branch from 2b673bb to 4649230 Compare September 16, 2025 01:40
@rspbot
Copy link

rspbot commented Sep 16, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Sep 16, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Sep 16, 2025

Build successful! 🎉

@jaslong jaslong mentioned this pull request Sep 21, 2025
Open
@LFDanLu LFDanLu mentioned this pull request Oct 7, 2025
Merged
5 tasks
@rspbot
Copy link

rspbot commented Oct 20, 2025

Build successful! 🎉

@reidbarber reidbarber enabled auto-merge October 20, 2025 17:50
@rspbot
Copy link

rspbot commented Oct 20, 2025

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit d169afa Oct 20, 2025
32 checks passed
@reidbarber reidbarber deleted the fix-overlay-positioning branch October 20, 2025 19:32
@sfc-gh-alisowski sfc-gh-alisowski mentioned this pull request Oct 21, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Popover combined with Menu is not flipped when the content doesn't fit useOverlayPosition wrong position when boundary element is set

4 participants

@snowystinger @rspbot @reidbarber @LFDanLu