feat: testing s2 icons refactor with foundations #3007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- removes spectrum-gray-800-rgb for background-color - creates new --spectrum-well-background-color in themes/spectrum- two.css with previous gray-800-rgb token to use instead
- removes raw rgb value for box-shadow - creates new --spectrum-assetcard-selectionindicator-box-shadow-color in themes/spectrum-two.css with previous rgb value to use instead
- Fixes an issue where line height had reverted back to a previous version, this brings line height back to the latest main - There were previous issues where CSS did not match latest main (such as not incorporating latest vendor prefix work), these properties were added/removed as needed without changing the latest updated order of properties
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- rebuilds tokens so the new --spectrum-gray-800-rgb custom tokens get added to tokens/dist/index.css
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The import of node path and use of path.basename was causing an error with Vite: "Module "path" has been externalized for browser compatibility. Cannot access "path.basename" in client code." This can't be used without a polyfill of some sort. The JSON icon data strings did not contain any file structure, so this was just removing the .svg file extension; this now uses a simpler string replace.
Resolve major differences between main and the s2 icons branch after rebase. Improves comments and handles/logs additional errors. Updates icon loader and utilities to use new format without medium/large scale, and changed icon directories. Some notable fixes made after a couple issues were encountered: - Replaces some deprecated S1 icons with S2 icons in docs example story. - Fixes issue with wrong UI icon size sometimes being displayed in Icon Template (Arrow 100 was being replaced with Arrow 400). - Fixes ordering with alphaNumericSort due to regex not matching
Include s2 icons branch CSS changes in the CSS that has moved to different files in the foundations branch refactor.
Updated tokens package version with icons and icons spacing related token value changes, for testing with S2 icons. Includes results of yarn build.
🦋 Changeset detectedLatest commit: a394381 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jawinn
added
research
|
🚀 Deployed on https://pr-3007--spectrum-css.netlify.app |
File metricsSummaryTotal size: 10.99 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsaccordion
actionbar
actionbutton
actiongroup
alertbanner
alertdialog
asset
assetcard
assetlist
avatar
badge
breadcrumb
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
helptext
icon
illustratedmessage
infieldbutton
inlinealert
link
logicbutton
menu
miller
modal
opacitycheckerboard
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
taggroup
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
tokens
page
site
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
9 tasks
Incorporate latest changes to ui-icons from the foundations branch, that included a change to one of the build commands.
Remove changesets from when foundations was merged into this testing branch. Leaving only changesets related to this testing branch and the snapshot releases to be made from it.
Inspired by @GarthDB and Spectrum Tokens, this adds an on-demand snapshot release workflow. Any user with write access can trigger the workflow to run against a branch and a snapshot release will be published from there based upon the changeset(s) added to the branch's commit history.
castastrophe
added
skip_vrt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A test that combines the S2 icons refactor v2 ( #3001 ) with the foundations branch ( #2786 ). Intended for previewing the look of the updated icons, using the the following tokens snapshot (with updated spacing/padding etc):
@adobe/spectrum-tokens": "0.0.0-s2-foundations-20240628172417Not intended for merging.