Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testing s2 icons refactor with foundations #3007

Closed
wants to merge 54 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
abd6f31
feat: foundations + gray remappings; architectural updates s2
castastrophe Jul 24, 2024
42a9b68
chore: storybook coverage enhancements
castastrophe Jul 23, 2024
395c01a
chore: release latest updates
castastrophe Jul 26, 2024
b88a57b
chore: release (s2-foundations) (#2942)
github-actions[bot] Jul 26, 2024
4f34727
fix: actionbutton invalid custom prop name
castastrophe Jul 29, 2024
8ba8dfe
chore: release (s2-foundations) (#2952)
github-actions[bot] Jul 29, 2024
f3cf31a
fix: keyframes being stripped from index-base
castastrophe Jul 31, 2024
e199954
build: improving theming approach
castastrophe Jul 31, 2024
efd9fe9
chore: release (s2-foundations) (#2959)
github-actions[bot] Jul 31, 2024
b69d7c7
fix: a few variable typos and flatten accordion var stack
castastrophe Aug 2, 2024
7434262
chore: release (s2-foundations) (#2964)
github-actions[bot] Aug 2, 2024
9480886
fix(accordion): variable typo
castastrophe Aug 6, 2024
a1c8683
chore: color viewer
castastrophe Aug 7, 2024
01708a2
fix(SWC-235): meter properties moved back to index.css
castastrophe Aug 7, 2024
0d379bc
chore: 3 bug fixes from SWC
castastrophe Aug 7, 2024
2289d8b
chore: release (s2-foundations) (#2978)
github-actions[bot] Aug 7, 2024
ffd838d
build: commit metadata assets to surface in diffs
castastrophe Aug 7, 2024
c45768c
chore(storybook): new gradient backgrounds; component details naming …
castastrophe Aug 7, 2024
b780ee8
chore: changesets and base styles update
castastrophe Aug 7, 2024
0947388
chore: changeset for search
castastrophe Aug 7, 2024
f85782e
chore: release (s2-foundations) (#2981)
github-actions[bot] Aug 7, 2024
abcdf63
fix(SWC-233): fixed action bar does not take full width
rise-erpelding Aug 8, 2024
0b47933
chore: release (s2-foundations) (#2983)
github-actions[bot] Aug 8, 2024
7a246c7
fix(SWC-240): picker button border color should be transparent
rise-erpelding Aug 12, 2024
1c08d26
chore: release (s2-foundations) (#2993)
github-actions[bot] Aug 12, 2024
cf46a9f
fix(SWC-241): fix dropzone missing dragged bg color
rise-erpelding Aug 8, 2024
303d92b
fix(dropzone): rgb tokens not defined
rise-erpelding Aug 13, 2024
ff5d48d
chore: release (s2-foundations) (#2995)
github-actions[bot] Aug 13, 2024
5458220
chore: fresh ci build updates
castastrophe Aug 13, 2024
47d0cdf
chore: new linter to validate theme assets; lint fixes
castastrophe Aug 13, 2024
23c5dee
chore: spectrum 2 imports added to the storybook templates
castastrophe Aug 13, 2024
0e08995
fix(SWC-248): static black selected actionbutton color should be white
rise-erpelding Aug 14, 2024
9c59c60
fix: change import path for CSS tokens
rise-erpelding Aug 14, 2024
29814ff
chore: build fixes
rise-erpelding Aug 15, 2024
c9d4925
chore: release (s2-foundations) (#2998)
github-actions[bot] Aug 15, 2024
c3d799f
fix(well): replace rgb with new custom property
marissahuysentruyt Aug 15, 2024
745dcbf
fix(assetcard): replace rgb value with new custom property
marissahuysentruyt Aug 15, 2024
9df688a
chore(assetcard,well): create changeset
marissahuysentruyt Aug 15, 2024
9294678
fix(SWC-306): textfield line height should match previous
rise-erpelding Aug 16, 2024
a663999
chore: release (s2-foundations) (#2999)
github-actions[bot] Aug 16, 2024
ac00b09
fix(well): rgb token not defined
marissahuysentruyt Aug 15, 2024
fa60db9
chore: rebuild tokens and create changeset
marissahuysentruyt Aug 16, 2024
1d1cbfc
fix(tokens): adjust custom rgb tokens for dropzone
rise-erpelding Aug 16, 2024
9caa1bc
chore: release (s2-foundations) (#3000)
github-actions[bot] Aug 16, 2024
148cf8e
feat(icon): updated s2 icons - workflow and ui
castastrophe May 30, 2024
4c08d2d
fix(icon): clear up vite error related to node path module
jawinn Aug 14, 2024
420eb92
fix(icon): incorporate diverged changes with fixes
jawinn Aug 14, 2024
fef4ab1
Merge branch 's2-foundations-redux' into jawinn/test-s2-icons-with-fo…
jawinn Aug 19, 2024
d0aa566
fix(icon): integrate s2 icon css changes into foundations refactor
jawinn Aug 19, 2024
3069154
build: updated tokens version snapshot for icon testing
jawinn Aug 19, 2024
efcfc96
feat(ui-icons): latest changes from foundations branch
jawinn Sep 17, 2024
ba1fb83
chore: remove changesets unrelated to this testing branch
jawinn Sep 17, 2024
cad4579
chore(tokens): add changeset for snapshot release
jawinn Sep 17, 2024
a394381
ci: add snapshot release workflow
pfulton Sep 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 0 additions & 8 deletions .changeset/blue-duck-prove.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/giant-rats-confess.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/gorgeous-impalas-invent.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/tokens": patch
---

Snapshot release that includes icon related changes to paddings for foundations.
73 changes: 73 additions & 0 deletions .changeset/olive-tools-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
---
"@spectrum-css/ui-icons": major
---

# Breaking change

Iconography in v1 inclued 2 sizes, `medium` and `large`, as well as a single SVG asset that included both versions to be toggled with classes via CSS (found in folder`combined`). Icons in v2 no longer have multiple sizes and all assets are sourced from a single folder`svg` which can be found in the `dist` directory of this workspace. **Raw SVG assets can no longer be sourced from the top-level of the workspace and must be loaded from `@spectrum-css/ui-icons/dist/svg/*.svg` instead.** Please find below an outline of the new, deprecated, and unchanged icons.

| Icon name | Migration notes |
| ----------------- | --------------- |
| Add50 | **New** |
| Add75 | **New** |
| Add100 | **New** |
| Add200 | **New** |
| Add300 | **New** |
| Arrow75 | Deprecated |
| Arrow100 | - |
| Arrow200 | Deprecated |
| Arrow300 | Deprecated |
| Arrow400 | - |
| Arrow500 | Deprecated |
| Arrow600 | Deprecated |
| Asterisk75 | Deprecated |
| Asterisk100 | - |
| Asterisk200 | - |
| Asterisk300 | - |
| Checkmark50 | - |
| Checkmark75 | - |
| Checkmark100 | - |
| Checkmark200 | - |
| Checkmark300 | - |
| Checkmark400 | - |
| Checkmark500 | Deprecated |
| Checkmark600 | Deprecated |
| Chevron50 | - |
| Chevron75 | - |
| Chevron100 | - |
| Chevron200 | - |
| Chevron300 | - |
| Chevron400 | - |
| Chevron500 | Deprecated |
| Chevron600 | Deprecated |
| CornerTriangle75 | - |
| CornerTriangle100 | - |
| CornerTriangle200 | - |
| CornerTriangle300 | - |
| Cross75 | - |
| Cross100 | - |
| Cross200 | - |
| Cross300 | - |
| Cross400 | - |
| Cross500 | - |
| Cross600 | - |
| Dash50 | - |
| Dash75 | - |
| Dash100 | - |
| Dash200 | - |
| Dash300 | - |
| Dash400 | Deprecated |
| Dash500 | Deprecated |
| Dash600 | Deprecated |
| DragHandle75 | **New** |
| DragHandle100 | **New** |
| DragHandle200 | **New** |
| DragHandle300 | **New** |
| Gripper100 | **New** |
| SingleGripper | Deprecated |
| DoubleGripper | Deprecated |
| TripleGripper | Deprecated |
| LinkOut100 | **New** |
| LinkOut200 | **New** |
| LinkOut300 | **New** |
| LinkOut400 | **New** |
137 changes: 137 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
{
"mode": "pre",
"tag": "s2-foundations",
"initialVersions": {
"@spectrum-css/preview": "10.1.0",
"@spectrum-css/accordion": "5.1.2",
"@spectrum-css/actionbar": "8.1.1",
"@spectrum-css/actionbutton": "6.1.1",
"@spectrum-css/actiongroup": "5.1.0",
"@spectrum-css/actionmenu": "6.1.1",
"@spectrum-css/alertbanner": "2.2.0",
"@spectrum-css/alertdialog": "2.1.1",
"@spectrum-css/asset": "5.1.1",
"@spectrum-css/assetcard": "4.1.1",
"@spectrum-css/assetlist": "6.1.1",
"@spectrum-css/avatar": "7.1.1",
"@spectrum-css/badge": "4.1.1",
"@spectrum-css/breadcrumb": "9.1.1",
"@spectrum-css/button": "13.1.1",
"@spectrum-css/buttongroup": "7.1.1",
"@spectrum-css/calendar": "5.1.2",
"@spectrum-css/card": "8.1.1",
"@spectrum-css/checkbox": "9.1.1",
"@spectrum-css/clearbutton": "6.1.1",
"@spectrum-css/closebutton": "5.1.1",
"@spectrum-css/coachindicator": "2.1.1",
"@spectrum-css/coachmark": "7.1.1",
"@spectrum-css/colorarea": "5.1.1",
"@spectrum-css/colorhandle": "8.1.1",
"@spectrum-css/colorloupe": "5.1.1",
"@spectrum-css/colorslider": "6.1.1",
"@spectrum-css/colorwheel": "4.1.1",
"@spectrum-css/combobox": "3.1.2",
"@spectrum-css/commons": "10.0.1",
"@spectrum-css/contextualhelp": "3.1.1",
"@spectrum-css/datepicker": "3.2.1",
"@spectrum-css/dial": "3.1.1",
"@spectrum-css/dialog": "10.1.1",
"@spectrum-css/divider": "3.1.1",
"@spectrum-css/dropindicator": "5.1.1",
"@spectrum-css/dropzone": "6.1.1",
"@spectrum-css/fieldgroup": "5.1.1",
"@spectrum-css/fieldlabel": "8.1.1",
"@spectrum-css/floatingactionbutton": "2.1.1",
"@spectrum-css/helptext": "5.1.1",
"@spectrum-css/icon": "7.1.1",
"@spectrum-css/illustratedmessage": "7.1.1",
"@spectrum-css/infieldbutton": "5.1.1",
"@spectrum-css/inlinealert": "8.1.1",
"@spectrum-css/link": "5.1.1",
"@spectrum-css/logicbutton": "4.1.1",
"@spectrum-css/menu": "7.1.3",
"@spectrum-css/miller": "6.1.1",
"@spectrum-css/modal": "5.1.1",
"@spectrum-css/opacitycheckerboard": "2.1.1",
"@spectrum-css/pagination": "8.1.1",
"@spectrum-css/picker": "8.1.3",
"@spectrum-css/pickerbutton": "5.1.1",
"@spectrum-css/popover": "7.1.3",
"@spectrum-css/progressbar": "4.1.2",
"@spectrum-css/progresscircle": "3.1.1",
"@spectrum-css/radio": "9.2.2",
"@spectrum-css/rating": "5.1.1",
"@spectrum-css/search": "7.1.2",
"@spectrum-css/sidenav": "5.1.1",
"@spectrum-css/slider": "5.2.3",
"@spectrum-css/splitview": "5.2.1",
"@spectrum-css/statuslight": "7.1.1",
"@spectrum-css/steplist": "5.1.1",
"@spectrum-css/stepper": "6.1.2",
"@spectrum-css/swatch": "6.1.1",
"@spectrum-css/swatchgroup": "3.1.1",
"@spectrum-css/switch": "5.1.1",
"@spectrum-css/table": "6.1.1",
"@spectrum-css/tabs": "5.1.1",
"@spectrum-css/tag": "9.1.1",
"@spectrum-css/taggroup": "5.1.1",
"@spectrum-css/textfield": "7.1.3",
"@spectrum-css/thumbnail": "6.1.2",
"@spectrum-css/toast": "10.1.1",
"@spectrum-css/tooltip": "6.1.2",
"@spectrum-css/tray": "3.1.1",
"@spectrum-css/treeview": "10.2.1",
"@spectrum-css/typography": "6.1.1",
"@spectrum-css/underlay": "4.1.1",
"@spectrum-css/well": "5.2.1",
"@spectrum-css/generator": "4.0.2",
"@spectrum-css/tokens": "14.2.0",
"@spectrum-css/ui-icons": "1.1.2",
"@spectrum-tools/gh-action-file-diff": "2.0.6",
"@spectrum-tools/postcss-add-theming-layer": "2.1.1-s2-foundations.0",
"@spectrum-tools/postcss-property-rollup": "2.0.1",
"@spectrum-tools/postcss-rgb-mapping": "2.0.0",
"@spectrum-tools/stylelint-no-missing-var": "2.0.0",
"@spectrum-tools/stylelint-no-unknown-custom-properties": "2.0.0",
"@spectrum-tools/stylelint-no-unused-custom-properties": "2.0.0",
"@spectrum-tools/documentation": "2.0.2",
"@spectrum-tools/theme-alignment": "0.0.0"
},
"changesets": [
"big-hats-happen",
"blue-duck-prove",
"calm-socks-speak",
"cyan-actors-rest",
"fair-parents-rush",
"gentle-ties-hang",
"giant-rats-confess",
"gold-countries-fly",
"good-dots-thank",
"heavy-sheep-drive",
"itchy-candles-develop",
"khaki-coats-unite",
"little-adults-melt",
"lovely-ducks-listen",
"modern-beds-provide",
"modern-tips-look",
"moody-shirts-kick",
"olive-buttons-join",
"orange-ants-yawn",
"orange-numbers-do",
"purple-chairs-melt",
"real-beans-serve",
"real-colts-perform",
"selfish-singers-lie",
"seven-pens-collect",
"sharp-pianos-reply",
"sharp-rice-sing",
"sharp-vans-flow",
"silent-carpets-beam",
"sixty-ears-heal",
"strong-hotels-type",
"tall-tomatoes-punch",
"tasty-years-cheat",
"three-buckets-walk",
"tiny-stingrays-kneel"
]
}
3 changes: 3 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ WATCH_MODE=true
NX_VERBOSE_LOGGING=false
NX_SKIP_NX_CACHE=false
NX_PERF_LOGGING=false

ARTIFACTORY_API_KEY=
ARTIFACTORY_API_TOKEN=
8 changes: 8 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@
]
}
},
{
"files": ["metadata.json"],
"parser": "jsonc-eslint-parser",
"extends": ["plugin:jsonc/recommended-with-jsonc"],
"rules": {
"jsonc/sort-keys": [0]
}
},
{
"files": ["project.json"],
"rules": {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:

- name: Lint component styles
if: ${{ inputs.styles_added_files != '' || inputs.styles_modified_files != '' }}
uses: reviewdog/action-stylelint@v1.28.0
uses: reviewdog/action-stylelint@v1.18.1
with:
fail_on_error: true
level: error
Expand All @@ -89,7 +89,7 @@ jobs:
stylelint_config: stylelint.config.js

- name: Run eslint on packages and stories
uses: reviewdog/action-eslint@v1.31.0
uses: reviewdog/action-eslint@v1.20.0
if: ${{ inputs.eslint_added_files != '' || inputs.eslint_modified_files != '' }}
with:
fail_on_error: true
Expand Down
55 changes: 55 additions & 0 deletions .github/workflows/release-snapshot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: Release Snapshot

on:
workflow_dispatch:
inputs:
tag:
description: "Tag used on changeset version and npm package"
required: false
type: string

jobs:
get-snapshot-tag:
runs-on: ubuntu-latest
permissions:
contents: write
id-token: write
steps:
- name: Split branch name
id: split
env:
BRANCH: ${{ github.ref_name }}
run: echo "fragment=${BRANCH##*snapshot-}" >> $GITHUB_OUTPUT
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Get last author info
id: author
run: |
echo "authorName=$(git log -1 --pretty=format:'%an')" >> $GITHUB_OUTPUT
echo "authorEmail=$(git log -1 --pretty=format:'%ae')" >> $GITHUB_OUTPUT
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Create snapshot release and publish to npm
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
SNAPSHOT_TAG: ${{ inputs.tag || steps.split.outputs.fragment }}
USERNAME: ${{ steps.author.outputs.authorName }}
EMAIL: ${{ steps.author.outputs.authorEmail }}
run: |
yarn changeset version --snapshot $SNAPSHOT_TAG && yarn --mode="update-lockfile"
yarn ci
git config --global user.name "$USERNAME"
git config --global user.email "$EMAIL"
git add .
git commit -m "chore: snapshot release $SNAPSHOT_TAG"
npm set //registry.npmjs.org/:_authToken=$NPM_TOKEN
yarn changeset publish --tag $SNAPSHOT_TAG
git push origin HEAD
git push --tags
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
dist
dist-site

## Keep the tokens rollup file as a sanity check for PRs
!tokens/dist/index.css
!tokens/dist/css/*.css
!tokens/dist/css/express/*.css
!tokens/dist/css/spectrum/*.css
!ui-icons/dist

# Not committing the map assets, these are dev-only
*.map
Expand Down
Loading
Loading