Skip to content

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 9, 2025

Description

This removes a duplicate story and the resulting VRT to preserve test accuracy.

Related issue(s)

  • fixes SWC-1033

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Manual review test cases

  1. Run the visual regression tests for the Card component.
  2. Confirm that only one “small quiet” test exists.
  3. Verify that the remaining test matches the production story visually and functionally.
  4. Ensure all Card tests pass

@cdransf cdransf self-assigned this Oct 9, 2025
Copy link

changeset-bot bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: 10c7599

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cdransf cdransf marked this pull request as ready for review October 9, 2025 20:01
@cdransf cdransf requested a review from a team as a code owner October 9, 2025 20:01
Copy link
Contributor

github-actions bot commented Oct 9, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5797

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Oct 9, 2025

Pull Request Test Coverage Report for Build 18469239065

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.957%

Totals Coverage Status
Change from base Build 18466717372: 0.0%
Covered Lines: 34182
Relevant Lines: 34716

💛 - Coveralls

@Rajdeepc
Copy link
Contributor

Can you shake off the VRT once more and update the hash. Looks good otherwise. Let me know when you are ready for another review?

Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good- thank you! All of the diffs are of this story, so I think that does it!

Copy link
Contributor

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 😄

@cdransf cdransf force-pushed the cdransf/card-small-quiet-test branch from 554f012 to f68d90f Compare October 13, 2025 14:34
@cdransf cdransf force-pushed the cdransf/card-small-quiet-test branch from f68d90f to fb61509 Compare October 13, 2025 15:17
@cdransf cdransf enabled auto-merge (squash) October 13, 2025 16:28
@cdransf cdransf merged commit 7963ed4 into main Oct 13, 2025
29 checks passed
@cdransf cdransf deleted the cdransf/card-small-quiet-test branch October 13, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants