Skip to content

fix(card): remove broken Small Quiet test #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
+2 −48
Merged

fix(card): remove broken Small Quiet test #5797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb61509
fix(card): remove broken Small Quiet test
cdransf Oct 9, 2025
10c7599
fix(card): update golden hash
cdransf Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ executors:
AZCOPY_TENANT_ID: $AZURE_TENANT_ID
parameters:
# In order to update the VRT baseline images:
# 1. Copy the hash of the latest golden images cache from the left sidebar in the VRT preview link (not to be confused with the arbitrary hash in the URL).
# 1. Copy the hash of the latest golden images hash from the left sidebar in the VRT preview link (not to be confused with the arbitrary hash in the URL).
# 2. Paste the hash in the current_golden_images_hash default parameter below.
# 3. Commit this change to the PR branch where the changes exist.
current_golden_images_hash:
type: string
default: 9b2f918bdfb7a5d90ac435f9cb103a9d35c263c9
default: fb61509de41ae6a2cd09fbcf661e20b9f270450b
wireit_cache_name:
type: string
default: wireit
Expand Down
46 changes: 0 additions & 46 deletions packages/card/stories/card.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,52 +78,6 @@ export const Default = (args: StoryArgs): TemplateResult => {
};
Default.args = {};

export const SmallQuiet = (args: StoryArgs): TemplateResult => {
const { onClick } = args;
return html`
<sp-card
heading="Card Heading"
subheading="JPG"
?toggles=${args.toggles !== undefined ? args.toggles : true}
?horizontal=${args.horizontal}
style="width: 200px;"
href="https://opensource.adobe.com/spectrum-web-components"
variant="quiet"
size="s"
@click=${(event: Event) => {
const composedTarget = event.composedPath()[0] as HTMLElement;
if (composedTarget.id !== 'like-anchor') return;
event.stopPropagation();
event.preventDefault();
onClick && onClick(event);
}}
>
<div slot="footer">
Footer with a
<sp-link href="https://google.com">link to Google</sp-link>
</div>
<sp-action-menu
label="More Actions"
slot="actions"
placement="bottom-end"
quiet
>
<sp-menu-item>Deselect</sp-menu-item>
<sp-menu-item>Select Inverse</sp-menu-item>
<sp-menu-item>Feather...</sp-menu-item>
<sp-menu-item>Select and Mask...</sp-menu-item>
<sp-menu-divider></sp-menu-divider>
<sp-menu-item>Save Selection</sp-menu-item>
<sp-menu-item disabled>Make Work Path</sp-menu-item>
</sp-action-menu>
<img slot="cover-photo" src=${portrait} alt="Demo Graphic" />
</sp-card>
`;
};
SmallQuiet.argTypes = {
onClick: { action: 'link click' },
};

export const href = (args: StoryArgs): TemplateResult => {
const { onClick } = args;
return html`
Expand Down
Loading