Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component page + basic Design system #468

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Component page + basic Design system #468

merged 11 commits into from
Dec 10, 2024

Conversation

adrienpoly
Copy link
Owner

@adrienpoly adrienpoly commented Nov 29, 2024

A cheap design system page

It can be helpfull when creating a component to test it in isolation. I didn't wanted to bring something like Lookbook at this point to remain light

CleanShot 2024-11-29 at 08 58 29@2x

@adrienpoly adrienpoly requested a review from marcoroth November 29, 2024 08:01
@adrienpoly
Copy link
Owner Author

in addition to the component page I have started to work a bit at improving our buttons by:

  1. reducing the amount of variants
  2. adjusting the style

So we would have 5 kinds only primary, secondary, ghost, link and pill

pill buttons would be dedicated to filters and toolbars and replace our current custom buttons

CleanShot 2024-12-03 at 08 41 39@2x

@adrienpoly adrienpoly changed the title add a very basic component page Component page + basic Design system Dec 3, 2024
@adrienpoly
Copy link
Owner Author

a preview is live on staging

This idea is to get a much shorter list of buttons with less variations

CleanShot 2024-12-09 at 00 36 37@2x

This PR also:

  • set the foundation for a tab component with the tabs Stimulus controller
  • adds a basic tooltip component that wraps tippy
  • adds an external_link_to helper
  • allow to pass options to the remote modal

@adrienpoly adrienpoly merged commit 244bdc0 into main Dec 10, 2024
4 checks passed
@adrienpoly adrienpoly deleted the components branch December 10, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant