-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component page + basic Design system #468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in addition to the component page I have started to work a bit at improving our buttons by:
So we would have 5 kinds only primary, secondary, ghost, link and pill
|
adrienpoly
changed the title
add a very basic component page
Component page + basic Design system
Dec 3, 2024
adrienpoly
force-pushed
the
components
branch
from
December 3, 2024 22:24
b4b62e1
to
ab8d429
Compare
adrienpoly
force-pushed
the
components
branch
from
December 9, 2024 00:21
ab8d429
to
a55ee19
Compare
a preview is live on staging This idea is to get a much shorter list of buttons with less variations This PR also:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cheap design system page
It can be helpfull when creating a component to test it in isolation. I didn't wanted to bring something like Lookbook at this point to remain light