Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Added cross-platform CI #249

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AnotherFoxGuy
Copy link
Contributor

Updated GitHub actions to run builds on Windows, Linux and MacOS
This uses Conan for installing the dependencies since it is the easiest way to get the cross-platform builds working
I will open a separate PR for generating artefacts that you can download and run for easy testing

@afritz1
Copy link
Owner

afritz1 commented May 16, 2023

Anything that improves our use of GitHub Actions is a good thing. First time hearing about Conan.

Just glanced through the changes. I think CMAKE_BUILD_TYPE should be ReleaseGeneric because I'm not using the default build types.

Can look more tonight.

@afritz1
Copy link
Owner

afritz1 commented May 16, 2023

I'd prefer avoiding changes to FindSDL2.cmake because I thought it's kind of a standard file. I don't understand the other CMake changes yet.

@Thunderforge
Copy link
Collaborator

To be clear: the usage will still keep us within the free tier of GitHub Actions, right? Given that there isn't any budget for this project, I think it would be rejected if it took us to the paid tier.

@AnotherFoxGuy
Copy link
Contributor Author

The usage will still keep us within the free tier of GitHub Actions, right?

Yes, it absolutely should
From the gh-actions docs: GitHub Actions usage is free for standard GitHub-hosted runners in public repositories and these builds should be optimized enough to run on the GitHub-hosted runners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants